do not check for user and host fields on accounts that do not have them in AccountManager.js

RESOLVED FIXED in Thunderbird 51.0

Status

MailNews Core
Account Manager
--
trivial
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({regression})

Trunk
Thunderbird 51.0
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.92 KB, patch
Magnus Melin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

2 years ago
After bug 791093 I was incorrectly fetching getFormElementValue() for type, user,host fields on any account, even those that didn't have them, like Local folders. Then getFormElementValue() was dumping that to the console.
(Assignee)

Comment 1

2 years ago
Created attachment 8779060 [details] [diff] [review]
patch
Attachment #8779060 - Flags: review?(mkmelin+mozilla)

Updated

2 years ago
Attachment #8779060 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 2

2 years ago
Thanks.
Keywords: checkin-needed

Comment 3

2 years ago
https://hg.mozilla.org/comm-central/rev/edaca1486019d810ac88f19e2c683d3483650027
Bug 1293408 - Do not check for user and host fields on accounts that do not have them in AccountManager.js. r=mkmelin

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
You need to log in before you can comment on or make changes to this bug.