Closed Bug 1293443 Opened 5 years ago Closed 5 years ago

Coalesce show/hide pairs for the same child node

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: michael.li11702, Assigned: michael.li11702)

References

Details

Attachments

(1 file)

If a child node gets shown and then hidden after, like when it is a text node that gets moved to be the child of another node before the document has completely loaded, then the show and hide events for the child under the original parent are unnecessary and will cause assertions; the child will be shown with the new parent anyway.
Assignee: nobody → mili
Depends on: 1289223
Comment on attachment 8779081 [details]
Bug 1293443: Coalesce show/hide pairs for the same child node

https://reviewboard.mozilla.org/r/70124/#review67652

::: accessible/base/EventTree.cpp:453
(Diff revision 1)
> +#ifdef A11Y_LOG
> +        logging::MsgBegin("EVENTS_TREE", "coalescing show/hide pair");
> +        logging::AccessibleInfo("removing show/hide pair for", ev->GetAccessible());
> +        logging::MsgEnd();
> +#endif
> +        mDependentEvents.RemoveElementAt(idx);

it's not that easy as a previous hide event may keep text change event from the coalescing hide event. Also this is n^2 processing, that'd be a perf killer, if we don't keep the numbers low.

Is it something must or nice to have? how does it lead to the assertions?
Comment on attachment 8779081 [details]
Bug 1293443: Coalesce show/hide pairs for the same child node

cancelling review for now
Attachment #8779081 - Flags: review?(surkov.alexander)
Closing since we didn't go with this approach.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.