1293449 - Stop exposing SurfaceCache implementation details to code outside of ImageLib

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

The fact that we #include SurfaceCache.h outside of ImageLib means that anything that SurfaceCache.h requires *also* needs to be exposed outside of ImageLib. It's time to put a stop to this.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Stop exposing SurfaceCache implementation code outside of ImageLib.

Here's the patch. The single use of SurfaceCache.h outside of ImageLib now uses
a wrapper class, SurfaceCacheUtils, instead. The implementation is no longer
exposed.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8779092 [details] [diff] [review]
Stop exposing SurfaceCache implementation code outside of ImageLib.

Review of attachment 8779092 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94d3d18441af
Stop exposing SurfaceCache implementation code outside of ImageLib. r=dholbert

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fee7ff6786ca
(Followup) - Remove unnecessary SurfaceCache.h #include from gfxWindowsPlatform. r=me

Comment 6

[Seth Fowler [:seth] [:s2h]]

Attachment: (Followup) - Remove unnecessary SurfaceCache.h #include from gfxWindowsPlatform.

gfxWindowsPlatform.cpp #include'd SurfaceCache.h unnecessarily.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/94d3d18441af
https://hg.mozilla.org/mozilla-central/rev/fee7ff6786ca