Closed Bug 1293449 Opened 3 years ago Closed 3 years ago

Stop exposing SurfaceCache implementation details to code outside of ImageLib

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: seth, Assigned: seth)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The fact that we #include SurfaceCache.h outside of ImageLib means that anything that SurfaceCache.h requires *also* needs to be exposed outside of ImageLib. It's time to put a stop to this.
Here's the patch. The single use of SurfaceCache.h outside of ImageLib now uses
a wrapper class, SurfaceCacheUtils, instead. The implementation is no longer
exposed.
Attachment #8779092 - Flags: review?(dholbert)
Blocks: 1293472
Comment on attachment 8779092 [details] [diff] [review]
Stop exposing SurfaceCache implementation code outside of ImageLib.

Review of attachment 8779092 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me
Attachment #8779092 - Flags: review?(dholbert) → review+
Thanks for the review!
Pushed by seth.bugzilla@blackhail.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94d3d18441af
Stop exposing SurfaceCache implementation code outside of ImageLib. r=dholbert
Pushed by seth.bugzilla@blackhail.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fee7ff6786ca
(Followup) - Remove unnecessary SurfaceCache.h #include from gfxWindowsPlatform. r=me
gfxWindowsPlatform.cpp #include'd SurfaceCache.h unnecessarily.
https://hg.mozilla.org/mozilla-central/rev/94d3d18441af
https://hg.mozilla.org/mozilla-central/rev/fee7ff6786ca
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.