1293467 - send tab notification has no icon

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[Edwin Wong [:edwong]]

Attachment: sendTabNotification.png

setup two profiles signed into the same sync acct
1. on desktop 1 - context click on page and send tab to all devices
2. on desktop 2 - poke sync now button

actual: you a notification with no image or icon

Comment 1

[Edwin Wong [:edwong]]

a Logo would spruce things up.  Also the originating device name italicized or on a new line would provide more visual clarity.

Comment 2

[Lina Butler [:lina]]

We did something similar for the "notifications upgraded" prompt: http://searchfox.org/mozilla-central/rev/d83f1528dbcb1e837d99cf5b6c36a90b03bf0e77/browser/components/nsBrowserGlue.js#2250-2253 Native notifications already use the app icon, and we specified the logo manually for XUL notifications.

Comment 3

[Ryan Feeley [:rfeeley]]

We should use the Firefox (or Aurora, Nightly, etc) icon like we do on OS X.

Comment 4

[Edouard Oger [:eoger]]

Attachment: tab_received_windows.png

Ryan is that ok?

Comment 5

[Ryan Feeley [:rfeeley]]

It looks a little big to me. Here are the guidelines that make it look like you can use the application icon, and not place it as a big image. https://msdn.microsoft.com/en-us/windows/uwp/controls-and-patterns/tiles-and-notifications-adaptive-interactive-toasts

Here is a the dropbox example. http://cdn.arstechnica.net/wp-content/uploads/2016/01/3-Interactive-toast-notifs.png

Comment 6

[Edouard Oger [:eoger]]

To be honest, I realized while setting up Sync for my tests that we don't have any icon for any of the new notifications we display (sync starting, validation email sent etc).
I think we should open a bug asking for a default icon, just like on OSX, in the Notifications component instead of trying to make an half-assed fix.

Comment 7

[Chris Karlof [:ckarlof]]

Kit, didn't you work on some of this code? Do you know why we don't get the default Firefox icon for Notifications on Windows?

Comment 8

[Lina Butler [:lina]]

(In reply to Chris Karlof [:ckarlof] from comment #7)
> Kit, didn't you work on some of this code? Do you know why we don't get the
> default Firefox icon for Notifications on Windows?

The simple answer is that the designs for XUL notifications (https://mozilla.invisionapp.com/share/3A4A895XZ#/screens/104465680) didn't call for an application icon if one wasn't specified. I think we considered using it in place of the favicon, but I'm not certain.

We don't control it on OS X, but, on Windows, it's up to us if we want a default. Let's file a bug in Toolkit :: Notifications, and we can discuss further. In the meantime, I think Edouard's patch is a good workaround.

(In reply to Ryan Feeley [:rfeeley] from comment #5)
> Here is a the dropbox example.
> http://cdn.arstechnica.net/wp-content/uploads/2016/01/3-Interactive-toast-
> notifs.png

Ryan, it looks like Dropbox uses native Windows notifications, which we don't implement yet. We can, of course, and probably should, but that's a separate chunk of work. ;-)

Comment 9

[Lina Butler [:lina]]

Ryan, do you have thoughts on using the oversize app icon vs. leaving it without an icon at all?

Comment 10

[Lina Butler [:lina]]

Or using a smaller icon. :-)

Comment 11

[Ryan Feeley [:rfeeley]]

We should use the smaller icon à la Dropbox example so that when we do move to native notifications, the transition is seamless.

Comment 12

[Edouard Oger [:eoger]]

Attachment: Bug 1293467 - Explicitely show icon on tab received notification on Windows.

Review commit: https://reviewboard.mozilla.org/r/73974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73974/

Comment 13

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8784617 [details]
Bug 1293467 - Explicitely show icon on tab received notification on Windows.

https://reviewboard.mozilla.org/r/73974/#review71890

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f2ee5d1f19b
Explicitely show icon on tab received notification on Windows. r=markh

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f2ee5d1f19b

Comment 16

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 x64 using Firefox 51 Beta 9 (buildID: 20161219140923): send tab notification has icon.