Closed
Bug 1293512
Opened 8 years ago
Closed 7 years ago
Support QR Code on iOS
Categories
(Firefox for iOS :: General, defect, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.22
| Tracking | Status | |
|---|---|---|
| fxios | 8.0+ | --- |
People
(Reporter: lyang, Assigned: justindarc)
References
(Depends on 2 open bugs)
Details
(Whiteboard: [MobileCore])
Attachments
(5 files, 2 obsolete files)
The design for QR Code
Support QR Code on iOS.
Support qr code by using AVFoundation framework.
Attachment #8782746 -
Flags: review?(sarentz)
Comment on attachment 8782746 [details] [review] pull request https://github.com/mozilla-mobile/firefox-ios/pull/2482
Attachment #8782746 -
Flags: review?(sarentz) → review?(fpatel)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8782746 [details] [review] pull request Sorry for getting to this so late. We are soon adding the ability to enable features by region. This could be a neat feature to enable for markets that use features like this. But this will need some form of tests. That might require some restructuring of the code but that would be a good change to make.
Attachment #8782746 -
Flags: review?(fpatel) → review-
Comment on attachment 8782746 [details] [review] pull request https://github.com/mozilla-mobile/firefox-ios/pull/2482
Attachment #8782746 -
Flags: review- → review?(sarentz)
|
||
Updated•7 years ago
|
Iteration: --- → 1.22
tracking-fxios:
--- → 8.0+
|
|
||
Updated•7 years ago
|
Attachment #8782746 -
Flags: review?(jdarcangelo)
|
|
||
Updated•7 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 5•7 years ago
|
||
Updated pull request
Attachment #8782746 -
Attachment is obsolete: true
Attachment #8782746 -
Flags: review?(sarentz)
Attachment #8782746 -
Flags: review?(jdarcangelo)
Attachment #8868625 -
Flags: review?(sarentz)
Attachment #8868625 -
Flags: review?(jdarcangelo)
|
|
||
Updated•7 years ago
|
Whiteboard: [MobileCore]
|
|
||
Updated•7 years ago
|
Assignee: nobody → lyang
|
|
||
Comment 6•7 years ago
|
||
This screenshot show the QR Code button in the menu from the New Tab page.
|
|
||
Comment 7•7 years ago
|
||
This screenshot show the QR Code button in the menu from an existing page. It is in the second page of the menu. Scanning a QR code does not replace the current page, it opens a new tab loading the new page.
|
|
||
Comment 8•7 years ago
|
||
This is the QR code scanner. It is full screen.
|
|
Assignee | |
Comment 9•7 years ago
|
||
Bryan, please attach the QR scanner icons to this bug when ready. Thanks!
Flags: needinfo?(bbell)
|
|
Assignee | |
Comment 10•7 years ago
|
||
Replacing the PR with a new one off a branch from the main mozilla-mobile "upstream" repo so we can collectively iterate on this before landing. Original commit is still attributed to Lynn.
Assignee: lyang → jdarcangelo
Attachment #8868625 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8868625 -
Flags: review?(sarentz)
Attachment #8868625 -
Flags: review?(jdarcangelo)
Attachment #8868783 -
Flags: review?(sarentz)
Attachment #8868783 -
Flags: review?(jdarcangelo)
|
|
||
Updated•7 years ago
|
Attachment #8868783 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Comment 11•7 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/39ee047b87d8964c50e6e9517c9e9295e4a73861 Landed on v8.x: https://github.com/mozilla-mobile/firefox-ios/commit/d65a416a361212111ea4d2843a32d68ca6e6944b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 12•7 years ago
|
||
Clearing NI? flag since follow-up Bug 1367832 has been filed for tracking the replacement of the QR icon.
Flags: needinfo?(bbell)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8868783 -
Flags: review?(jdarcangelo)
You need to log in
before you can comment on or make changes to this bug.
Description
•