Closed Bug 1293528 Opened 8 years ago Closed 8 years ago

clang-format gtests

Categories

(NSS :: Libraries, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mt, Assigned: mt)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This one is different to other code.  We've been using Google style for our tests.  We should make that formal.
Up on rietveld: https://codereview.appspot.com/302390043/

In this case, I saw no point in deviating from Google style.
lgtm, but I don't see a .clang-format file in the diff?
Flags: needinfo?(martin.thomson)
dammit rietveld:  it looks like this:
$ cat external_tests/.clang-format
---
Language: Cpp
BasedOnStyle: Google
...
Flags: needinfo?(martin.thomson)
Base patch (no formatting applied).
The patch that will rot very quickly.
Assignee: nobody → martin.thomson
Comment on attachment 8779571 [details] [diff] [review]
clang_format_gtest-2.patch

Review of attachment 8779571 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't check details, but looks good to me. Looks like the google style sorts includes. Something we explicitly disabled for the rest of the code base. That's fine with me but we should be aware of it.
Attachment #8779571 - Flags: review+
Shall we land this (it'll need rebasing)?
Flags: needinfo?(martin.thomson)
Rebasing is easy.

https://hg.mozilla.org/projects/nss/rev/06f9767b53cb
https://hg.mozilla.org/projects/nss/rev/bd032bda5d0a

Note that you can now run the following to make sure that your code is clang-format clean:

$ automation/taskcluster/scripts/run_clang_format.sh --apply
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(martin.thomson)
Resolution: --- → FIXED
Target Milestone: --- → 3.27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: