Closed
Bug 1293568
Opened 8 years ago
Closed 8 years ago
Remove unused file nsSOCKS4SocketProvider.h
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
1.50 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
nsSOCKS4SocketProvider.h is unused. (Note that NS_SOCKS4SOCKETPROVIDER_CID is defined both in nsSOCKS4SocketProvider *and* in nsNetCID.h.)
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8779192 -
Flags: review?(valentin.gosu)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d584974ef9c1
|
||
Updated•8 years ago
|
Whiteboard: [necko-active]
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8779192 [details] [diff] [review] Remove unused file nsSOCKS4SocketProvider.h Review of attachment 8779192 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8779192 -
Flags: review?(valentin.gosu) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/17daca58e46ecad0b5cb08fc2e39068ff44e54fc Bug 1293568 - Remove unused file nsSOCKS4SocketProvider.h. r=valentin.
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/17daca58e46e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•