Closed Bug 1293570 Opened 3 years ago Closed 3 years ago

Selection methods should not apply to input type=number

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jessica, Assigned: ehsan)

References

Details

Attachments

(1 file)

Per the current whatwg spec [1], selectionStart, selectionEnd, selectionDirection, setRangeText() and setSelectionRange() should only apply to input type=text, search, url, telephone and password. But since bug 1003741, we apply them to input type=number as well.

[1] https://html.spec.whatwg.org/multipage/forms.html#do-not-apply
Feel free to change the priority if you see fit, Jessica.
Priority: -- → P3
Blocks: 1003741
Ehsan, any idea why bug 1003741 happened?
Flags: needinfo?(ehsan)
Hmm, I'm not sure what I was thinking.  :(

We clearly should not support any of these for input type=number.
Assignee: nobody → ehsan
Flags: needinfo?(ehsan)
Depends on: 1297225
In particular we keep the frame a form control frame so that it gets the
correct CSS box sizing by the layout code.
Attachment #8783748 - Flags: review?(amarchesini)
Attachment #8783748 - Flags: review?(amarchesini) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f3b3f116e6a
Revert parts of bug 1003741 which were added to make selection APIs work on <input type=number>; r=baku
https://hg.mozilla.org/mozilla-central/rev/8f3b3f116e6a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.