shim Services exports the wrong thing

RESOLVED FIXED in Firefox 51

Status

enhancement
P1
normal
RESOLVED FIXED
3 years ago
10 months ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
Firefox 51
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [reserve-html])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The Services shim does

exports.Services = Services;

but it is generally required as:

const Services = require("Services");

So, we have to change how the shim is exporting.
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8779486 [details]
Bug 1293760 - change export in Services shim;

https://reviewboard.mozilla.org/r/70468/#review67786
Attachment #8779486 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 3

3 years ago
I tested an earlier version of this (yes, a one line patch with multiple versions)
and it didn't work in the webpack; but then I forgot to re-test when I fixed it,
and of course the tests don't define |module| and die...
Comment hidden (mozreview-request)

Comment 5

3 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bf7045fe191
change export in Services shim; r=bgrins

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3bf7045fe191
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.