Closed
Bug 1293760
Opened 8 years ago
Closed 8 years ago
shim Services exports the wrong thing
Categories
(DevTools :: Framework, enhancement, P1)
DevTools
Framework
Tracking
(firefox51 fixed)
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [reserve-html])
Attachments
(1 file)
The Services shim does
exports.Services = Services;
but it is generally required as:
const Services = require("Services");
So, we have to change how the shim is exporting.
Updated•8 years ago
|
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8779486 [details]
Bug 1293760 - change export in Services shim;
https://reviewboard.mozilla.org/r/70468/#review67786
Attachment #8779486 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 3•8 years ago
|
||
I tested an earlier version of this (yes, a one line patch with multiple versions)
and it didn't work in the webpack; but then I forgot to re-test when I fixed it,
and of course the tests don't define |module| and die...
Comment hidden (mozreview-request) |
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bf7045fe191
change export in Services shim; r=bgrins
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•