Closed Bug 1293760 Opened 4 years ago Closed 4 years ago
shim Services exports the wrong thing
The Services shim does exports.Services = Services; but it is generally required as: const Services = require("Services"); So, we have to change how the shim is exporting.
Iteration: --- → 51.1 - Aug 15
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Comment on attachment 8779486 [details] Bug 1293760 - change export in Services shim; https://reviewboard.mozilla.org/r/70468/#review67786
Attachment #8779486 - Flags: review?(bgrinstead) → review+
I tested an earlier version of this (yes, a one line patch with multiple versions) and it didn't work in the webpack; but then I forgot to re-test when I fixed it, and of course the tests don't define |module| and die...
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3bf7045fe191 change export in Services shim; r=bgrins
You need to log in before you can comment on or make changes to this bug.