1293760 - shim Services exports the wrong thing

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

The Services shim does

exports.Services = Services;

but it is generally required as:

const Services = require("Services");

So, we have to change how the shim is exporting.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1293760 - change export in Services shim;

Review commit: https://reviewboard.mozilla.org/r/70468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70468/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8779486 [details]
Bug 1293760 - change export in Services shim;

https://reviewboard.mozilla.org/r/70468/#review67786

Comment 3

[Tom Tromey :tromey]

I tested an earlier version of this (yes, a one line patch with multiple versions)
and it didn't work in the webpack; but then I forgot to re-test when I fixed it,
and of course the tests don't define |module| and die...

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8779486 [details]
Bug 1293760 - change export in Services shim;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70468/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bf7045fe191
change export in Services shim; r=bgrins

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3bf7045fe191