Closed Bug 1293806 Opened 3 years ago Closed 3 years ago
Animation Generation in ns Animation Manager::Update Animations could be removed
58 bytes, text/x-review-board-request
I don't have any evidences but it seems to me that UpdateAnimationGeneration in nsAnimationManager::UpdateAnimations can be removed. When UpdateAnimations is called, RequestRestyle(Layer) has to be called if a property of the animations is changed, and RequestRestyle(Layer) calls UpdateAnimationGeneration inside it. Currently UpdateAnimationGeneration is called even if there is no property changes? i.e.; div.style.animation = "anim 10s liner"; // A little after div.style.animation = "anim 10s liner"; ?
Note about automation test. We have various test cases in test_restyles.html to check whether animation kicks restyles or not. http://hg.mozilla.org/mozilla-central/file/01748a2b1a46/dom/animation/test/chrome/test_restyles.html We can add some test cases there. 1) setting the same animation style (just like in comment 0) 2) changing duration or delay or something.
Assignee: nobody → ra24483
Status: NEW → ASSIGNED
I'll write test cases for this.
Comment on attachment 8785535 [details] Bug 1293806 - Removed UpdateAnimationGeneration in nsAnimationManager::UpdateAnimations https://reviewboard.mozilla.org/r/74712/#review72638 Thanks!
Attachment #8785535 - Flags: review?(hiikezoe) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/414e2d95cffe Removed UpdateAnimationGeneration in nsAnimationManager::UpdateAnimations r=hiro
You need to log in before you can comment on or make changes to this bug.