1293806 - UpdateAnimationGeneration in nsAnimationManager::UpdateAnimations could be removed

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P5)

Description

[Hiroyuki Ikezoe (:hiro)]

I don't have any evidences but it seems to me that UpdateAnimationGeneration in nsAnimationManager::UpdateAnimations can be removed.

When UpdateAnimations is called, RequestRestyle(Layer) has to be called if a property of the animations is changed, and RequestRestyle(Layer) calls UpdateAnimationGeneration inside it.

Currently UpdateAnimationGeneration is called even if there is no property changes? i.e.;

  div.style.animation = "anim 10s liner";
  // A little after
  div.style.animation = "anim 10s liner";

?

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Note about automation test.  We have various test cases in test_restyles.html to check whether animation kicks restyles or not.

http://hg.mozilla.org/mozilla-central/file/01748a2b1a46/dom/animation/test/chrome/test_restyles.html

We can add some test cases there.

1) setting the same animation style (just like in comment 0)
2) changing duration or delay or something.

Comment 2

[skoji]

I'll write test cases for this.

Comment 3

[shundroid]

Attachment: Bug 1293806 - Removed UpdateAnimationGeneration in nsAnimationManager::UpdateAnimations

Review commit: https://reviewboard.mozilla.org/r/74712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74712/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8785535 [details]
Bug 1293806 - Removed UpdateAnimationGeneration in nsAnimationManager::UpdateAnimations

https://reviewboard.mozilla.org/r/74712/#review72638

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/414e2d95cffe
Removed UpdateAnimationGeneration in nsAnimationManager::UpdateAnimations r=hiro

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/414e2d95cffe