1293810 - Replace comments/assertions about "geometry box" with correct term, "reference box", in CSS shapes code

Status: NEW

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Bug 1110460 added some code with mentions of "geometry box" or "geometry-box" in CSS Shapes code.

The spec uses the term "reference box" instead -- and we use that same term in other code. We should clean up all of these "geometry box" usages to all say "reference box", in CSS-Shapes-related code.

(Bug 1269990 begins this process; and then there are a few more spots that need fixing.)

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I believe reference-box [1] is the term used in basic shape function, which is part of the syntax used by clip-path and shape-outside. I had replace most of the "geometry box" by "reference box" in part 6 and part 8 in bug 1288626. The only file I didn't touch is layout/style/StyleAnimationValue.cpp.

[1] https://drafts.csswg.org/css-shapes/#reference-box

Comment 2

[Daniel Holbert [:dholbert]]

Yeah, I'm seeing references to geometry-box in that file and in nsRuleNode.cpp:
 https://dxr.mozilla.org/mozilla-central/search?q=geometry-box

But: ah, hm. Just found the definition for geometry-box -- seems to be:
  https://drafts.fxtf.org/css-masking-1/#typedef-geometry-box

Maybe <geometry-box> describes the syntax, and "reference box" describes the concept?

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Re comment 2:

> Maybe <geometry-box> describes the syntax, and "reference box" describes the concept?

Yes. I think so. The reference box for basic shapes used in clip-path and shape-outside is <geometry-box> and <shape-box> [1], respectively.

[1] https://drafts.csswg.org/css-shapes/#typedef-shape-box

Comment 4

[u459114]

<geometry-box> may follow & be _reference_ by <basic-shape>