1293822 - /home/worker files should be owned by worker:worker

Status: RESOLVED FIXED

(Taskcluster Graveyard :: Docker Images, defect)

Description

[Gregory Szorc [:gps]]

2f0d6ea822b5 (bug 1163057) changed behavior of the "tester" Docker image to chown /home/worker to root:root instead of worker:worker. This code has been copied into the Ubuntu 12.04 and 16.04 desktop test images.

The existing code is:

# Remove once running under 'worker' user. This is necessary for pulseaudio to start
# XXX: change this back to worker:worker once permissions issues are resolved
RUN            chown -R root:root /home/worker

AFAICT, we su to the "worker" user pretty early in container start, before any pulseaudio code runs. So I'm pretty sure whatever permissions issues this is referring to have been resolved.

Let's change the Docker images to chown /home/worker as worker:worker.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1293822 - Have worker own /home/worker files;

This effectively reverts the change in 2f0d6ea822b5 (bug 1163057)
to own the files by root:root. Since that change landed, we su
to the "worker" user early during task startup. So there is no more
need to have /home/worker owned by root:root.

Review commit: https://reviewboard.mozilla.org/r/70536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70536/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8779565 [details]
Bug 1293822 - Have worker own /home/worker files;

https://reviewboard.mozilla.org/r/70536/#review68196

The Try push on this looks happy!

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8779565 [details]
Bug 1293822 - Have worker own /home/worker files;

https://reviewboard.mozilla.org/r/70536/#review68274

For the record, the pulseaudio troubles were documented in bug 1214809.  But the chown this patch removes was added in bug 1212411.  I think the comments at the beginning of bug 1214809 regarding pulseaudio never actually working were referencing, among other things, the chown in bug 1212411.  So as the try push confirms, this change will not cause regressions.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15fd5d4ddb7c
Have worker own /home/worker files; r=dustin

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/15fd5d4ddb7c