Move some configure arguments to moz.configure.

RESOLVED FIXED in Firefox 51

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

unspecified
mozilla51

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8779709 [details] [diff] [review]
Move --enable-gc-trace to moz.configure
Attachment #8779709 - Flags: review?(cmanchester)
(Assignee)

Comment 2

2 years ago
Created attachment 8779710 [details] [diff] [review]
Move --enable-perf to moz.configure
Attachment #8779710 - Flags: review?(cmanchester)
(Assignee)

Comment 3

2 years ago
Created attachment 8779711 [details] [diff] [review]
Move --enable-more-deterministic to moz.configure
Attachment #8779711 - Flags: review?(cmanchester)
Attachment #8779709 - Flags: review?(cmanchester) → review+
Attachment #8779710 - Flags: review?(cmanchester) → review+
Comment on attachment 8779711 [details] [diff] [review]
Move --enable-more-deterministic to moz.configure

Review of attachment 8779711 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good. Thank you for the patches.
Attachment #8779711 - Flags: review?(cmanchester) → review+
(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #5)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=71dbcdaab316&selectedJob=25194141

Any chance those spidermonkey failures on Windows are from this patch?
Flags: needinfo?(Ms2ger)
That's but 1291926.
Flags: needinfo?(Ms2ger)

Comment 8

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/030611acd766
Move --enable-gc-trace to moz.configure. r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c040933f259
Move --enable-perf to moz.configure. r=chmanchester
https://hg.mozilla.org/integration/mozilla-inbound/rev/18306e1c2b76
Move --enable-more-deterministic to moz.configure. r=chmanchester
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/030611acd766
https://hg.mozilla.org/mozilla-central/rev/8c040933f259
https://hg.mozilla.org/mozilla-central/rev/18306e1c2b76
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.