Closed Bug 1294071 Opened 4 years ago Closed 4 years ago

Move dispatchMemoryPressure out of nsAppShell.cpp

Categories

(Core :: Widget: Android, defect, P3)

All
Android
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

No description provided.
Move dispatchMemoryPressure out of GeckoAppShell and AndroidJNI.cpp
Attachment #8780173 - Flags: review?(snorp)
Comment on attachment 8780173 [details] [diff] [review]
Move dispatchMemoryPressure out of GeckoAppShell (v1)

Review of attachment 8780173 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/MemoryMonitor.h
@@ +17,5 @@
> +public:
> +    static void
> +    DispatchMemoryPressure()
> +    {
> +        NS_DispatchMemoryPressure(MemoryPressureState::MemPressure_New);

At first glance it seems like we should be running this on the main thread, but NS_DispatchMemoryPressure just calls NS_DispatchToMainThread() which of course can be called from any thread. Maybe worth a comment.
Attachment #8780173 - Flags: review?(snorp) → review+
Priority: -- → P3
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c088af8ed9
Move dispatchMemoryPressure out of GeckoAppShell; r=snorp
https://hg.mozilla.org/mozilla-central/rev/11c088af8ed9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.