1294071 - Move dispatchMemoryPressure out of nsAppShell.cpp

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect, P3)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Move dispatchMemoryPressure out of GeckoAppShell (v1)

Move dispatchMemoryPressure out of GeckoAppShell and AndroidJNI.cpp

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8780173 [details] [diff] [review]
Move dispatchMemoryPressure out of GeckoAppShell (v1)

Review of attachment 8780173 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/MemoryMonitor.h
@@ +17,5 @@
> +public:
> +    static void
> +    DispatchMemoryPressure()
> +    {
> +        NS_DispatchMemoryPressure(MemoryPressureState::MemPressure_New);

At first glance it seems like we should be running this on the main thread, but NS_DispatchMemoryPressure just calls NS_DispatchToMainThread() which of course can be called from any thread. Maybe worth a comment.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c088af8ed9
Move dispatchMemoryPressure out of GeckoAppShell; r=snorp

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11c088af8ed9