Closed Bug 1294094 Opened 8 years ago Closed 8 years ago

Investigating blacklist feature_webgl_opengl for intel

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
50 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1293028

People

(Reporter: ernest, Unassigned)

Details

Seems like the comment in the code does not match it's intention.

Please see https://dxr.mozilla.org/mozilla-central/source/widget/windows/GfxInfo.cpp#1185. 

The comment says "Older than 11-18-2015", but the driver version used in the code is any driver less than 20.19.15.4331. Using Intel's driver version scheme (http://www.intel.com/content/www/us/en/support/graphics-drivers/000005654.html), if we are blacklisting all drivers that are less than that driver version, that will be all drivers that are not windows 10 (and dx12) with the build number 4331. The third number in that scheme also seems to be an internal number that should not be used in blacklisting rules (or just set to 0).

If the intention is correct to blacklist all those drivers for webgl_opengl, we should update the comment to reflect the specifics - that we are blacklisting all drivers that are not windows 10 (and dx12) with the particular build number (which may in fact be from 11-18-2015).
ni?jgilbert since he added that. Was this intentionally targeting win 10 as described above?
Flags: needinfo?(jgilbert)
Nope! It's purely date-driven.
Flags: needinfo?(jgilbert)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.