1294142 - Crash in mozilla::dom::TextTrackManager::TimeMarchesOn

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is 
report bp-fd2604c9-95ca-448a-82a6-04c952160809.
=============================================================
Crashing Thread (0)
Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::dom::TextTrackManager::TimeMarchesOn() 	dom/html/TextTrackManager.cpp:535
1 	xul.dll 	nsRunnableMethodImpl<void ( nsBindingManager::*)(void), 1, 0>::Run() 	obj-firefox/dist/include/nsThreadUtils.h:749
2 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp:1067
3 	xul.dll 	mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp:100
4 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc:228

this cross-platform signature is regressing in firefox 49 and looks related to the work from bug 882718. 
according to crash stats data this is currently making up 0.11% of all browser crashes in 49.0b1.

Comment 1

[Benjamin Chen [:bechen]]

Obviously the mTextTracks been null out by CC unlink, then TimeMarchesOn() crash.

Comment 2

[Benjamin Chen [:bechen]]

Attachment: Bug 1294142 - TextTrackManager::mTextTracks is null after CC.

Review commit: https://reviewboard.mozilla.org/r/70874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70874/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8780033 [details]
Bug 1294142 - TextTrackManager::mTextTracks is null after CC.

https://reviewboard.mozilla.org/r/70874/#review68260

Comment 4

[Benjamin Chen [:bechen]]

Attachment: bug1294142.aurora.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1280814
[User impact if declined]: possible crash at the end of playback.
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: low risk, simple fix.
[String/UUID change made/needed]: none

Comment 5

[Benjamin Chen [:bechen]]

Attachment: bug1294142.beta.patch

Approval Request Comment
[Feature/regressing bug #]: 1280814
[User impact if declined]: possible crash at the end of playback.
[Describe test coverage new/current, TreeHerder]: none.
[Risks and why]: low risk, simple fix.
[String/UUID change made/needed]: none

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Though this is a simple fix, I would still like to see how this does on Nightly51 before uplifting to Aurora50.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b20a8ee1249
TextTrackManager::mTextTracks is null after CC. r=jwwang

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8b20a8ee1249

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

The last crashes on nightly 51 are from 20160815030201, so nothing since 2 days ago on Nightly. That sounds promising for uplift. Ritu, giving it one more day and if there still aren't new crashes tomorrow, let's uplift to aurora + beta.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #9)
> The last crashes on nightly 51 are from 20160815030201, so nothing since 2
> days ago on Nightly. That sounds promising for uplift. Ritu, giving it one
> more day and if there still aren't new crashes tomorrow, let's uplift to
> aurora + beta.

Yup, looked at the crash stats and nothing shows up on Nightly since the fix landed. So we should be good. I'll A+ for both Beta49 and Aurora50.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b3c6b197d3ef

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/90d0af29d7dc