1294155 - Autoclassify keyboard shortcuts don't work when radio buttons are focused from being clicked

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:key_shortcut_input > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8779808 [details] [review]
[treeherder] mozilla:key_shortcut_input > mozilla:master

Not sure about this one, though maybe there's something I'm missing. See PR for details.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8779808 [details] [review]
[treeherder] mozilla:key_shortcut_input > mozilla:master

This looks good on the whole, except for one nit. Could you seperate out the various refactorings and changes into a separate commits? as it is, it's pretty hard to see exactly what pertains to the specific change in the bug and what is more general cleanup. r+ with that addressed.

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6bc046636d50b5f76edf704a84cece22e7800edb
Bug 1294155 - Remove focus-this directive in favour of normal .focus() method

https://github.com/mozilla/treeherder/commit/c95a59b3a63f07714b7e32b63b55bcf088dec2a1
Bug 1294155 - Refactor key events handling.

Move the key events into an array, and bind once when the controller is
initalized rather than every keypress. Deal with special cases by providing
the option to override the stopCallback behaviour on a per-combo basis
rather than by dynamically unbinding and rebinding keys.

https://github.com/mozilla/treeherder/commit/90782ca9257772254861a6f30a6a2aa0a906a208
Bug 1294155 - Don't disable keyboard shortcuts when input type=checkbox|radio have focus.

Comment 5

[Jonathan French (:jfrench)]

Hi, I did a quick run through of most of the shortcuts on jgraham's github pages excluding retrigger and the new autoclassify save, and compared against current stage.

The only regression I appear to observe, is bug 1118342, when issuing a classification save shortcut (ctrl + enter) and the bugnumber or comment field has focus, it should save. To reproduce:

o Select a job
o 'c' to focus the comment field, or 'b' to enter a bug number
o type something into that field
o 'ctrl + enter'

Expected behavior
o Logged out, we should immediately see a bootstrap notification you're not logged in
o Logged in, we should immediately save the classification

Observed (github pages, logged out)
o nothing happens

On pages, issuing a 2nd 'ctrl + enter' I do observe the bootstrap notification. I am guessing that if it was possible to be logged in on pages, the first keyboard attempt wouldn't have saved the classification.

Comment 6

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:key_shortcut_input_1 > mozilla:master

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/53317088be6006b2a9fc641fb6624af4ade2d1c1
Bug 1294155 - Make ctrl+enter work irrespective of which element has focus. (#1782)