webidl hook rejected a commit it should have accepted

NEW
Unassigned

Status

Developer Services
Mercurial: hg.mozilla.org
a year ago
11 months ago

People

(Reporter: KWierso, Unassigned)

Tracking

Details

(Reporter)

Description

a year ago
I attempted to land something very much like this commit to aurora, but it was rejected by the webidl hook.
https://hg.mozilla.org/releases/mozilla-aurora/rev/d67e58e5ad8c
The original commit message was:
"Bug 1291078 - Expose ChromeOnly openInParentProcess property on <select> elements. r=Enn,r=mrbkap a=lizzard"

To get the hook to accept it, I switched the order of the two reviewers.


Shouldn't the findAll() in https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/prevent_webidl_changes.py#l100 have checked both of them?
QA Contact: hwine → klibby
You need to log in before you can comment on or make changes to this bug.