1294190 - shim Services disallows observation of a pref

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

event-emitter does:

    Services.prefs.addObserver("devtools.dump.emit", {

but the shim Services rejects this.
This has to be fixed.  Maybe just removing the exception is enough.

Comment 1

[Tom Tromey :tromey]

It also came up that the shim tries to read all the items in localstorage;
but this is too eager, as a tool might reasonably use localstorage for something else.

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1294190 - fix latent problems in test_service_prefs.html;

Review commit: https://reviewboard.mozilla.org/r/70786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70786/

Comment 3

[Tom Tromey :tromey]

Attachment: Bug 1294190 - allow observation of a preference in shim prefs;

Review commit: https://reviewboard.mozilla.org/r/70788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70788/

Comment 4

[Tom Tromey :tromey]

Attachment: Bug 1294190 - prefix local storage keys used by prefs;

Review commit: https://reviewboard.mozilla.org/r/70790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70790/

Comment 5

[Greg Tatum [:gregtatum]]

Comment on attachment 8779875 [details]
Bug 1294190 - prefix local storage keys used by prefs;

https://reviewboard.mozilla.org/r/70790/#review68370

LGTM!

Comment 6

[Greg Tatum [:gregtatum]]

Comment on attachment 8779873 [details]
Bug 1294190 - fix latent problems in test_service_prefs.html;

https://reviewboard.mozilla.org/r/70786/#review68372

Nice catch.

Comment 7

[Greg Tatum [:gregtatum]]

Comment on attachment 8779874 [details]
Bug 1294190 - allow observation of a preference in shim prefs;

https://reviewboard.mozilla.org/r/70788/#review68356

Everything looks good on my end, thanks.

::: devtools/client/shared/shim/test/test_service_prefs.html:206
(Diff revision 1)
>      "somestring": true
>    }, "removeObserver worked");
>  
> +  clearNotificationList();
> +  branch0.addObserver("devtools.branch1.somestring", observer, false);
> +  Services.prefs.setCharPref("devtools.branch1.somestring", "northern shoveler");

Nice choice of animal.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3370d5a24a15
fix latent problems in test_service_prefs.html; r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/975288a373b8
allow observation of a preference in shim prefs; r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/7605d95cd9df
prefix local storage keys used by prefs; r=gregtatum

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3370d5a24a15
https://hg.mozilla.org/mozilla-central/rev/975288a373b8
https://hg.mozilla.org/mozilla-central/rev/7605d95cd9df