Closed Bug 1294390 Opened 8 years ago Closed 7 years ago

WebExtensions webRequest api throws "TabManger is not defined" on Firefox for Android

Categories

(WebExtensions :: Android, defect, P2)

51 Branch
defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1260548
webextensions +

People

(Reporter: bugzilla, Assigned: mattw)

References

Details

(Whiteboard: [tab] triaged)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160810004000
Firefox for Android

Steps to reproduce:

Built an XPI based on the https://github.com/mdn/webextensions-examples/tree/master/user-agent-rewriter sample project that uses the webRequest API.

Configured Firefox for Android Nightly to allow unsigned addons

Installed addon XPI

Connected from desktop using WebUI


Actual results:

Addon loaded, but had no effect other than being listed in Addons.

Console reports:
TabManager is not defined       ext-webRequest.js:29



Expected results:

No error should have been reported.
Component: Untriaged → WebExtensions
Product: Firefox → Toolkit
Thanks for filing this bug.

The TabManager is currently only implemented on Desktop, so we'll either have to remove the dependency on it from webRequest or add support for it on Android.

Bug 1260548 is the tracking bug to add support for the Tabs API on Android (which will include the implementation of the TabManager).
Depends on: 1260548
Taking a quick peek at ext-webRequest.js I notice that TabManager is only used once, to get a tabId, and that tabId is only used to check that the tab exists at all (not -1). Seems to me that a quick fix might be to simply not do that, and remove the reference to TabManager...
leave out tabID on android
Assignee: nobody → mwein
Priority: -- → P2
Whiteboard: [tab] triaged
Component: WebExtensions → WebExtensions: Android
webextensions: --- → +
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.