Move onSurfaceTextureFrameAvailable out of AndroidJNI.cpp

RESOLVED FIXED in Firefox 51

Status

()

Core
Widget: Android
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

unspecified
mozilla51
All
Android
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Move onSurfaceTextureFrameAvailable out of AndroidJNI.cpp and re-implement it as a
native method in GeckoAppShellSupport.
(Assignee)

Comment 1

2 years ago
Created attachment 8780190 [details] [diff] [review]
Move onSurfaceTextureFrameAvailable out of AndroidJNI.cpp (v1)

Move onSurfaceTextureFrameAvailable out of AndroidJNI.cpp and into a
new-style native method implemented in nsAppShell.cpp.
Attachment #8780190 - Flags: review?(snorp)
Comment on attachment 8780190 [details] [diff] [review]
Move onSurfaceTextureFrameAvailable out of AndroidJNI.cpp (v1)

Review of attachment 8780190 [details] [diff] [review]:
-----------------------------------------------------------------

Actually I was thinking we could do a lot better with this one. We could create a SurfaceTexture subclass that uses a native method to dispatch the frame listener callback to AndroidSurfaceTexture. Then we could remove the junk in GeckoAppShell altogether. Can you do that instead?
Attachment #8780190 - Flags: review?(snorp) → review-
Priority: -- → P3
(Assignee)

Comment 3

2 years ago
Created attachment 8783079 [details] [diff] [review]
Rip out old Java code for AndroidSurfaceTexture (v1)

Rip out the old GeckoAppShell methods for frame available callback.
Attachment #8783079 - Flags: review?(snorp)
(Assignee)

Updated

2 years ago
Attachment #8780190 - Attachment is obsolete: true
(Assignee)

Comment 4

2 years ago
Created attachment 8783080 [details] [diff] [review]
Implement new frame available callbacks (v1)

Implement a new OnFrameAvailableListener callback system for
AndroidSurfaceTexture using native methods. Each AndroidSurfaceTexture
creates its own SurfaceTextureListener object and uses it to forward
OnFrameAvailableListener callbacks to the corresponding nsIRunnable.
Attachment #8783080 - Flags: review?(snorp)
(Assignee)

Comment 5

2 years ago
Created attachment 8783081 [details] [diff] [review]
Update auto-generated bindings (v1)
Attachment #8783081 - Flags: review+
Attachment #8783079 - Flags: review?(snorp) → review+
Comment on attachment 8783080 [details] [diff] [review]
Implement new frame available callbacks (v1)

Review of attachment 8783080 [details] [diff] [review]:
-----------------------------------------------------------------

Much nicer.
Attachment #8783080 - Flags: review?(snorp) → review+

Comment 7

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c447a8c81c6
Rip out old Java code for AndroidSurfaceTexture; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/84529160c383
Implement new frame available callbacks; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/fce9511bf4ea
Update auto-generated bindings; r=me

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3c447a8c81c6
https://hg.mozilla.org/mozilla-central/rev/84529160c383
https://hg.mozilla.org/mozilla-central/rev/fce9511bf4ea
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.