1294526 - Check for unexpected hide events in removeGrandChildrenNHideParent

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Michael Li]

Add checks to make sure grandchildren don't fire hide events since the parent will be hidden anyway.

Comment 1

[Michael Li]

Attachment: Bug 1294526: Check for unexpected hide/reorder events in removeGrandChildrenNHideParent

Review commit: https://reviewboard.mozilla.org/r/70970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/70970/

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8780273 [details]
Bug 1294526: Check for unexpected hide/reorder events in removeGrandChildrenNHideParent

https://reviewboard.mozilla.org/r/70970/#review68488

::: accessible/tests/mochitest/events/test_coalescence.html:326
(Diff revision 1)
>        this.eventSeq = [
>          new invokerChecker(EVENT_HIDE, getAccessible(aParentId)),
> -        new invokerChecker(EVENT_REORDER, getNode(aParentId).parentNode)
> +        new invokerChecker(EVENT_REORDER, getNode(aParentId).parentNode),
> +        new unexpectedInvokerChecker(EVENT_HIDE, getAccessible(aChild1Id)),
> +        new unexpectedInvokerChecker(EVENT_HIDE, getAccessible(aChild2Id))
>        ];

it might be nice to check there's no reorder on parent too, otherwise looks ok

Comment 3

[Michael Li]

Comment on attachment 8780273 [details]
Bug 1294526: Check for unexpected hide/reorder events in removeGrandChildrenNHideParent

https://reviewboard.mozilla.org/r/70970/#review68488

> it might be nice to check there's no reorder on parent too, otherwise looks ok

Do you mean check for no reorders on the two childs? Since we expect the reorder on the parent.

Comment 4

[Michael Li]

Comment on attachment 8780273 [details]
Bug 1294526: Check for unexpected hide/reorder events in removeGrandChildrenNHideParent

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70970/diff/1-2/

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Michael Li from comment #3)
> Comment on attachment 8780273 [details]
> Bug 1294526: Check for unexpected hide/reorder events in
> removeGrandChildrenNHideParent
> 
> https://reviewboard.mozilla.org/r/70970/#review68488
> 
> > it might be nice to check there's no reorder on parent too, otherwise looks ok
> 
> Do you mean check for no reorders on the two childs? Since we expect the
> reorder on the parent.

nope, there is a reorder event for parent's parent, and reorder on parent is unexpected.

Comment 6

[Michael Li]

Comment on attachment 8780273 [details]
Bug 1294526: Check for unexpected hide/reorder events in removeGrandChildrenNHideParent

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70970/diff/2-3/

Comment 7

[Michael Li]

Does it look good now? I'm not sure if parentNode vs. parentElement would make a difference.

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Michael Li from comment #7)
> Does it look good now? I'm not sure if parentNode vs. parentElement would
> make a difference.

aChild1Id and aChild2Id have common parent, which is aParentId, so only one checker for aParentId is needed

Comment 9

[Michael Li]

(In reply to alexander :surkov from comment #8)
> (In reply to Michael Li from comment #7)
> > Does it look good now? I'm not sure if parentNode vs. parentElement would
> > make a difference.
> 
> aChild1Id and aChild2Id have common parent, which is aParentId, so only one
> checker for aParentId is needed

Oh I see, so we're checking to make sure there's no extra reorder on aParentId.

Comment 10

[Michael Li]

Never mind, I didn't realize the expected reorder is for aParentId's parent, oops.

Comment 11

[Michael Li]

Comment on attachment 8780273 [details]
Bug 1294526: Check for unexpected hide/reorder events in removeGrandChildrenNHideParent

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/70970/diff/3-4/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/608c36e6b0f7
Check for unexpected hide/reorder events in removeGrandChildrenNHideParent. r=surkov

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/608c36e6b0f7