Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Nika, Assigned: Nika)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently, we pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl such that it can be returned from GetChildSheet. This is unnecessary, as the only method which is called on the return value of GetChildSheet appears to be Show, which is a method on nsIWidget. 

This patch changes nsCocoaWindow to return a nsIWidget instead of a nsCocoaWindow.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8780300 [details]
Bug 1294553 - Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl,

https://reviewboard.mozilla.org/r/71010/#review68512
Attachment #8780300 - Flags: review?(mstange) → review+

Comment 3

2 years ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a9a9ea21a18
Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl, r=mstange

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9a9a9ea21a18
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.