Closed
Bug 1294620
Opened 8 years ago
Closed 8 years ago
Use infallible XPIDL attribute getters more
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
40.46 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
For any XPIDL attribute marked with [infallible] we generate an infallible getter that wraps the fallible getter and asserts that it succeeds. There are plenty of places in the codebase where we don't take advantage of these infallible getters.
|
Assignee | |
Comment 1•8 years ago
|
||
This makes a lot of code more compact, and also avoids some redundant nsresult checks. The patch also removes a handful of redundant checks on infallible setters.
Attachment #8780379 -
Flags: review?(erahm)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8780379 [details] [diff] [review] Use infallible XPIDL attribute getters more Review of attachment 8780379 [details] [diff] [review]: ----------------------------------------------------------------- r=me. Nice cleanup!
Attachment #8780379 -
Flags: review?(erahm) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef4aaae8d79bb6ca37b88d3440db1247fa10e260 Bug 1294620 - Use infallible XPIDL attribute getters more. r=erahm.
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ef4aaae8d79b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•