Closed Bug 1294630 Opened 4 years ago Closed 4 years ago

Move --enable-ipc-fuzzer to python configure

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1294630 - Move --enable-ipc-fuzzer to python configure.
58 bytes, text/x-review-board-request
chmanchester
: review+
Details 
No description provided.
Comment on attachment 8780396 [details]
Bug 1294630 - Move --enable-ipc-fuzzer to python configure.

https://reviewboard.mozilla.org/r/71128/#review68882

::: toolkit/moz.configure:484
(Diff revision 1)
> +# Gecko integrated IPC fuzzer
> +# ==============================================================
> +option('--enable-ipc-fuzzer', env='MOZ_FAULTY',
> +       help='Enable IPC fuzzer')
> +
> +@depends_if('--enable-ipc-fuzzer', target)

`depends_if` proceeds if any argument is truthy, which `target` will be, so this fails outright on Windows.
Attachment #8780396 - Flags: review?(cmanchester)
Comment on attachment 8780396 [details]
Bug 1294630 - Move --enable-ipc-fuzzer to python configure.

https://reviewboard.mozilla.org/r/71128/#review69614
Attachment #8780396 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bbe53526d74
Move --enable-ipc-fuzzer to python configure. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/2bbe53526d74
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.