1294634 - Use a switch statement to convert State to string

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/0502bd9e025edde29777ba1de4280f9b52af4663/dom/media/MediaDecoderStateMachine.cpp#l1045

We got screwed whenever adding a field without changing this string table.

A switch statement can warn us when the fields are not exhausted.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1294634 - Use a switch statement to convert State to string.

Review commit: https://reviewboard.mozilla.org/r/71148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71148/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8780408 [details]
Bug 1294634 - Use a switch statement to convert State to string.

https://reviewboard.mozilla.org/r/71148/#review68628

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8780408 [details]
Bug 1294634 - Use a switch statement to convert State to string.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71148/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b74ee1d97db
Use a switch statement to convert State to string. r=bechen

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7b74ee1d97db