1294651 - iterationComposite feature should be behind dom.animations-api.core.enabled pref

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

We can reuse the function which will be introduced in bug 1293106 to check the pref value.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

We should check the pref both in the constructor and the setter.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> We should check the pref both in the constructor and the setter.

And silently set the value to 'replace' if the pref is false.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> > We should check the pref both in the constructor and the setter.
> 
> And silently set the value to 'replace' if the pref is false.

Or just a no-op.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> We should check the pref both in the constructor and the setter.

http://hg.mozilla.org/mozilla-central/file/82d0a583a9a3/dom/animation/KeyframeEffectReadOnly.cpp#l513
and
http://hg.mozilla.org/mozilla-central/file/82d0a583a9a3/dom/animation/KeyframeEffect.cpp#l132

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Taking since this needs to be uplifted to Aurora now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5678caed8d3

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Sorry, I accidentally removed priority.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1294651 - Don't apply iterationComposite value if the preference for Web Animations API is not enabled.

Review commit: https://reviewboard.mozilla.org/r/79624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79624/

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Hi Boris, could you please take a look of this patch?  Thanks.

Comment 9

[Boris Chiou [:boris]]

Comment on attachment 8792716 [details]
Bug 1294651 - Don't apply iterationComposite value if the preference for Web Animations API is not enabled.

https://reviewboard.mozilla.org/r/79624/#review78672

Looks good to me.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8792716 [details]
Bug 1294651 - Don't apply iterationComposite value if the preference for Web Animations API is not enabled.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79624/diff/1-2/

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Thank you Boris!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/300cecbe4c61
Don't apply iterationComposite value if the preference for Web Animations API is not enabled. r=boris

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8792716 [details]
Bug 1294651 - Don't apply iterationComposite value if the preference for Web Animations API is not enabled.

Approval Request Comment
[Feature/regressing bug #]: bug 1216843
[User impact if declined]: A feature of some feature set of the Web Animation API is exposed even if the feature set is not yet shipped.
[Describe test coverage new/current, TreeHerder]: The patch includes a test case
[Risks and why]: Extremely low it's just do no-op if the pref for the feature set is not enabled.
[String/UUID change made/needed]: None

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/300cecbe4c61

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8792716 [details]
Bug 1294651 - Don't apply iterationComposite value if the preference for Web Animations API is not enabled.

This patch fixes a pref value for Web Animations API. Take it in 51 aurora.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4095b6940207