Prepare the search reset feature for a Shield study

RESOLVED FIXED in Firefox 49

Status

()

Firefox
Search
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: florian, Assigned: florian)

Tracking

unspecified
Firefox 51
Points:
---

Firefox Tracking Flags

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

a year ago
Product Management has decided that we need data about how the search reset feature performs on actual release users before deploying it to all our user base. I'll attach here patches to prepare the code for this. We'll need to pref the feature off for 49 so that the Shield study can re-enable it.
(Assignee)

Comment 1

a year ago
Created attachment 8780518 [details] [diff] [review]
remove the engine drop down,
Attachment #8780518 - Flags: review?(past)
(Assignee)

Updated

a year ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8780518 [details] [diff] [review]
remove the engine drop down,

Review of attachment 8780518 [details] [diff] [review]:
-----------------------------------------------------------------

Is there another bug for adding telemetry to the "settings" link?
Attachment #8780518 - Flags: review?(past) → review+
(Assignee)

Comment 3

a year ago
Created attachment 8780528 [details] [diff] [review]
instrument the 'Settings page' button
Attachment #8780528 - Flags: review?(past)
(Assignee)

Comment 4

a year ago
Created attachment 8780529 [details] [diff] [review]
pref off the search reset feature for 49

Note: removing the browser/app/profile/firefox.js entry makes us fallback to the default (false) from modules/libpref/init/all.js
Attachment #8780529 - Flags: review?(past)
Comment on attachment 8780528 [details] [diff] [review]
instrument the 'Settings page' button

Review of attachment 8780528 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, there it is!
Attachment #8780528 - Flags: review?(past) → review+
Attachment #8780529 - Flags: review?(past) → review+
(Assignee)

Comment 6

a year ago
https://hg.mozilla.org/integration/fx-team/rev/d1e65973534f70fbced2f0f22746eca2f00b37aa
Bug 1294680 - remove the engine drop down, r=past.

https://hg.mozilla.org/integration/fx-team/rev/124669ed2f09f68f7f8dd38f4fee5f3084da0aff
Bug 1294680 - instrument the 'Settings page' button, r=past.
(Assignee)

Comment 7

a year ago
Comment on attachment 8780518 [details] [diff] [review]
remove the engine drop down,

Approval Request Comment
[Feature/regressing bug #]: bug 1203168
[Describe test coverage new/current, TreeHerder]: The patch adapts the existing automated test coverage.
[Risks and why]: Low risk, this is mostly a UI simplification/removal, and the feature will be pref'ed off for 49.
[String/UUID change made/needed]: none.
Attachment #8780518 - Flags: approval-mozilla-beta?
Attachment #8780518 - Flags: approval-mozilla-aurora?
status-firefox49: --- → affected
status-firefox50: --- → affected
status-firefox51: --- → affected
(Assignee)

Comment 8

a year ago
Comment on attachment 8780528 [details] [diff] [review]
instrument the 'Settings page' button

Approval Request Comment
[Feature/regressing bug #]: bug 1203168
[impact if declined]: Impossible for us to distinguish people clicking the Settings link from people who just closed the prompt when looking at Telemetry data.
[Describe test coverage new/current, TreeHerder]: This change is covered by the included change to our automated test.
[Risks and why]: Low, this is just improving our telemetry recording of how the page is used.
[String/UUID change made/needed]: none.
Attachment #8780528 - Flags: approval-mozilla-beta?
Attachment #8780528 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 9

a year ago
Comment on attachment 8780529 [details] [diff] [review]
pref off the search reset feature for 49

Approval Request Comment
[Feature/regressing bug #]: bug 1203168
[User impact if declined]: the search reset feature would be exposed before we have data to prove that it actually has the desired effect.
[Describe test coverage new/current, TreeHerder]: N/A.
[Risks and why]: low, just pref'ing the feature off for one cycle for now.
[String/UUID change made/needed]: none.
Attachment #8780529 - Flags: approval-mozilla-beta?
Comment on attachment 8780518 [details] [diff] [review]
remove the engine drop down,

From discussion in email, please uplift to aurora and beta. This should make it into beta 4.
Attachment #8780518 - Flags: approval-mozilla-beta?
Attachment #8780518 - Flags: approval-mozilla-beta+
Attachment #8780518 - Flags: approval-mozilla-aurora?
Attachment #8780518 - Flags: approval-mozilla-aurora+
Comment on attachment 8780529 [details] [diff] [review]
pref off the search reset feature for 49

Please uplift this patch to beta only.
Attachment #8780529 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8780528 - Flags: approval-mozilla-beta?
Attachment #8780528 - Flags: approval-mozilla-beta+
Attachment #8780528 - Flags: approval-mozilla-aurora?
Attachment #8780528 - Flags: approval-mozilla-aurora+
(Actually, hold off on uplift until this lands on m-c)

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d1e65973534f
https://hg.mozilla.org/mozilla-central/rev/124669ed2f09
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Comment 14

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/a6c0964964be
https://hg.mozilla.org/releases/mozilla-aurora/rev/0d2e9c07cc9a
status-firefox50: affected → fixed

Comment 15

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/c250152accdc
https://hg.mozilla.org/releases/mozilla-beta/rev/1ab4e3c7085d
https://hg.mozilla.org/releases/mozilla-beta/rev/eb93bd0c50d6
status-firefox49: affected → fixed
(Assignee)

Updated

a year ago
See Also: → bug 1301784
You need to log in before you can comment on or make changes to this bug.