1294685 - `viewSourceInDebugger` doesn't fall back to view-source: tab

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect, P2)

Description

[James Long (:jlongster)]

The old functionality of `viewSourceInDebugger` would open the URL in a new view-source: tab if the debugger didn't have a source with that URL. The new debugger doesn't do this because you don't know if the debugger is still initializing and the source just hasn't been created yet. It just tells the debugger to show that URL, and the debugger waits if the source doesn't exist yet.

The old code solved this by explicitly waiting for all sources to be loading (in `viewSourceInDebugger`), but that's problematic because there is no notion of "all sources loaded". New sources may appear at any time. However, maybe we can figure out a way to indicate that the debugger is finished initializing or not.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

This should get done before we ship but doesn't need to block turning the debugger on.

Comment 2

[Eddy Bruel [:ejpbruel]]

(In reply to Bryan Clark (DevTools PM) [@clarkbw] from comment #1)
> This should get done before we ship but doesn't need to block turning the
> debugger on.

This reads to me as: this bug is important, but not a blocker, and is not currently being worked on. Based on that, I'm triaging this bug as P2.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I tested this and works for me.

If the source URL in question isn't known to debugger view-source: is used as fall back.

Related place in the code base:
https://searchfox.org/mozilla-central/rev/6e3cc153566f5f288ae768a2172385b8436d61dd/devtools/client/shared/view-source.js#61

Honza