1294729 - Fix logging so autoland doesn't get stuck

Status: RESOLVED FIXED

(Conduit Graveyard :: Transplant, defect)

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: autoland: don't reference an undefined variable in the error case (Bug 1294729).

cmd_output was being referenced in the exception handler, but when
run_hg() would fail it is never assigned. This was causing autoland
to repeatedly loop on a single changeset due to how it would handle
this unexpected exception.

We should no longer get stuck on a single revision when the related
invocation of run_hg() fails.

Review commit: https://reviewboard.mozilla.org/r/71260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71260/

Comment 2

[Steven MacLeod [:smacleod]]

Attachment: autoland: add more logging around transplant (Bug 1294729).

In order to diagnose errors with transplanting add more logging. This
is a bit of a temporary fix and autoland logging should have a bit of
a rework, but that will be left to a followup. This should be good
enough for now.

Review commit: https://reviewboard.mozilla.org/r/71262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71262/

Comment 3

[:glob ✱]

Comment on attachment 8780563 [details]
autoland: don't reference an undefined variable in the error case (Bug 1294729).

https://reviewboard.mozilla.org/r/71260/#review69002

Comment 4

[:glob ✱]

Comment on attachment 8780564 [details]
autoland: add more logging around transplant (Bug 1294729).

https://reviewboard.mozilla.org/r/71262/#review69004

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/2c1e48dd6769
autoland: don't reference an undefined variable in the error case . r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/3371b0e1a90e
autoland: add more logging around transplant . r=glob

Comment 6

[:glob ✱]

deployed to production.