Backout the patches from bug 1271165 once the instrumentation has served its purpose.

RESOLVED FIXED in Firefox 51

Status

()

Core
Memory Allocator
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ehoogeveen, Assigned: ehoogeveen)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The patches in bug 1271165 are landing without review as a temporary measure to diagnose a crash (bug 1124397). Once that purpose has been served, I'll back them out again in this bug.

The crashes aren't very frequent, so we'll probably need to leave the instrumentation in for at least a week or so to see if anything turns up, but I'll make sure they're backed out before we branch.
[Tracking Requested - why for this release]:

We can track for 51 as a reminder to back out bug 1271165 before Aurora merge day.
status-firefox50: --- → unaffected
tracking-firefox51: --- → ?
Priority: -- → P1
Tracking 51+ for all the reasons in Comment 1.
tracking-firefox51: ? → +
(Assignee)

Comment 3

2 years ago
Created attachment 8784005 [details] [diff] [review]
Back out all of bug 1271165 as it has served its purpose.

This is a simple backout, with two exceptions:
1) it leaves in the trailing whitespace removal for mozjemalloc and
2) it leaves in two fixes for harmless typos that I came across while writing the glue code (s/MALLOC_FUNS/MALLOC_FUNCS/ for two places that include malloc_decls.h).
Attachment #8784005 - Flags: review?(mh+mozilla)
Attachment #8784005 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab461807ca14
Back out all of bug 1271165 as it has served its purpose. r=glandium
Keywords: checkin-needed

Comment 6

2 years ago
backoutbugherder
https://hg.mozilla.org/mozilla-central/rev/ab461807ca14
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.