1294732 - Backout the patches from bug 1271165 once the instrumentation has served its purpose.

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect, P1)

Description

[Emanuel Hoogeveen [:ehoogeveen]]

The patches in bug 1271165 are landing without review as a temporary measure to diagnose a crash (bug 1124397). Once that purpose has been served, I'll back them out again in this bug.

The crashes aren't very frequent, so we'll probably need to leave the instrumentation in for at least a week or so to see if anything turns up, but I'll make sure they're backed out before we branch.

Comment 1

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

We can track for 51 as a reminder to back out bug 1271165 before Aurora merge day.

Comment 2

[Marcia Knous [:marcia]]

Tracking 51+ for all the reasons in Comment 1.

Comment 3

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: Back out all of bug 1271165 as it has served its purpose.

This is a simple backout, with two exceptions:
1) it leaves in the trailing whitespace removal for mozjemalloc and
2) it leaves in two fixes for harmless typos that I came across while writing the glue code (s/MALLOC_FUNS/MALLOC_FUNCS/ for two places that include malloc_decls.h).

Comment 4

[Emanuel Hoogeveen [:ehoogeveen]]

Build-only try run just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4184706d8792

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab461807ca14
Back out all of bug 1271165 as it has served its purpose. r=glandium

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ab461807ca14