1294844 - groupOf shell function should use getGroup(cx)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Naomi Smith [:spinda] (non-bmo mail: [e-mail])]

...to handle lazy groups properly.

Comment 1

[Naomi Smith [:spinda] (non-bmo mail: [e-mail])]

Attachment: Bug 1294844: groupOf shell function should use getGroup(cx)

Comment 2

[Shu-yu Guo [:shu]]

Comment on attachment 8780696 [details] [diff] [review]
Bug 1294844: groupOf shell function should use getGroup(cx)

Review of attachment 8780696 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +3119,5 @@
>          JS_ReportError(cx, "groupOf: object expected");
>          return false;
>      }
>      JSObject* obj = &args[0].toObject();
> +    args.rval().set(JS_NumberValue(double(uintptr_t(obj->getGroup(cx)) >> 3)));

Need to null-check the return value of getGroup(cx)

Comment 3

[Shu-yu Guo [:shu]]

Comment on attachment 8780696 [details] [diff] [review]
Bug 1294844: groupOf shell function should use getGroup(cx)

Review of attachment 8780696 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsobj.cpp
@@ -3442,5 @@
>              (void*) globalObj, globalObj->getClass()->name);
>      const Class* clasp = obj->getClass();
>      fprintf(fp, "class %p %s\n", (const void*)clasp, clasp->name);
> -    const ObjectGroup* group = obj->group();
> -    fprintf(fp, "group %p\n", (const void*)group);

If you're so inclined, you could still print this if !hasLazyGroup(), and print something else if hasLazyGroup()

Comment 4

[Naomi Smith [:spinda] (non-bmo mail: [e-mail])]

Attachment: Bug 1294844: groupOf shell function should use getGroup(cx)

Like this?

Comment 5

[Naomi Smith [:spinda] (non-bmo mail: [e-mail])]

Attachment: Bug 1294844: groupOf shell function should use getGroup(cx)

I've incorporated both the null check and the hasLazyGroup check in dumpObject.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31530f6106bf
groupOf shell function should use getGroup(cx) to handle lazy groups properly. r=shu

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/31530f6106bf