Move MOZ_PERMISSIONS to python configure

RESOLVED FIXED in Firefox 51

Status

()

Core
Build Config
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8781220 [details]
Bug 1294864 - Move MOZ_PERMISSIONS to Python configure.

https://reviewboard.mozilla.org/r/71662/#review69264

::: old-configure.in
(Diff revision 1)
>  fi
>  
>  AC_SUBST(MOZ_PULSEAUDIO)
>  
>  dnl ========================================================
> -dnl Permissions System

There's a default MOZ_PERMISSIONS=1 set on line 2348. Which means we don't want an "env" for this option since an existing environment variable was ignored.

::: toolkit/moz.configure:449
(Diff revision 1)
>      if places and android_history:
>          die('Cannot use MOZ_ANDROID_HISTORY alongside MOZ_PLACES.')
>  
> +# Permissions system
> +# ==============================================================
> +

we usually don't put an empty line between the "header" and the option()
Attachment #8781220 - Flags: review?(mh+mozilla)
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8781220 [details]
Bug 1294864 - Move MOZ_PERMISSIONS to Python configure.

https://reviewboard.mozilla.org/r/71662/#review69662
Attachment #8781220 - Flags: review?(mh+mozilla) → review+

Comment 5

a year ago
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04d3df949cab
Move MOZ_PERMISSIONS to Python configure. r=glandium

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/04d3df949cab
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.