Closed Bug 1294864 Opened 3 years ago Closed 3 years ago

Move MOZ_PERMISSIONS to python configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8781220 [details]
Bug 1294864 - Move MOZ_PERMISSIONS to Python configure.

https://reviewboard.mozilla.org/r/71662/#review69264

::: old-configure.in
(Diff revision 1)
>  fi
>  
>  AC_SUBST(MOZ_PULSEAUDIO)
>  
>  dnl ========================================================
> -dnl Permissions System

There's a default MOZ_PERMISSIONS=1 set on line 2348. Which means we don't want an "env" for this option since an existing environment variable was ignored.

::: toolkit/moz.configure:449
(Diff revision 1)
>      if places and android_history:
>          die('Cannot use MOZ_ANDROID_HISTORY alongside MOZ_PLACES.')
>  
> +# Permissions system
> +# ==============================================================
> +

we usually don't put an empty line between the "header" and the option()
Attachment #8781220 - Flags: review?(mh+mozilla)
Comment on attachment 8781220 [details]
Bug 1294864 - Move MOZ_PERMISSIONS to Python configure.

https://reviewboard.mozilla.org/r/71662/#review69662
Attachment #8781220 - Flags: review?(mh+mozilla) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04d3df949cab
Move MOZ_PERMISSIONS to Python configure. r=glandium
https://hg.mozilla.org/mozilla-central/rev/04d3df949cab
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.