Closed Bug 1294885 Opened 3 years ago Closed 3 years ago

The bookmarks toolbar doesn't have enough padding from the edge of the window

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 51
Tracking Status
firefox51 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

On Windows we give the back button `padding-inline-start: 5px;` but we don't have any padding for the bookmarks toolbar items which can appear pushed up against the edge of the window. This looks unpolished.
OSX already has padding: 0 4px 4px; for the #PersonalToolbar. I used the respective padding-inline-start values for the #back-button for Windows and Linux.
Doesn't this patch break fitts' law for the bookmarks toolbar?
Flags: needinfo?(jaws)
Yes, it does. But I don't think it's something we need to optimize for here. Not all buttons need the fitts law treatment, mainly buttons that we specifically want users to be able to hit quickly, such as the back button and menu button.

We could put the padding inside of the button but that will make the hover state look weird due to how we draw these buttons.

> #PersonalToolbar > #personal-bookmarks > #PlacesToolbar > hbox >#PlacesToolbarItems > .bookmark-item:first-child > .toolbarbutton-icon {
>   margin-inline-start: 5px;
> }
Flags: needinfo?(jaws)
Comment on attachment 8780743 [details]
Bug 1294885 - Apply padding to the start and end of the Bookmarks Toolbar so bookmark items don't appear abutted to the edge of the window.

You can just write padding: 1px 4px on Linux. While you're at it, maybe also move it to the next rule with the same selector except for :not(#addon-bar)? You're reusing the same rule on Windows (where you can probably write padding: 0 5px too).
Attachment #8780743 - Flags: review?(dao+bmo)
Comment on attachment 8780743 [details]
Bug 1294885 - Apply padding to the start and end of the Bookmarks Toolbar so bookmark items don't appear abutted to the edge of the window.

Still need to remove the redundant #navigator-toolbox > toolbar:not(#toolbar-menubar):not(#TabsToolbar):not(#nav-bar) rule on Linux
Attachment #8780743 - Flags: review?(dao+bmo)
I left it because removing it would remove the padding from the addon-bar.
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> I left it because removing it would remove the padding from the addon-bar.

That toolbar is always hidden.
Attachment #8780743 - Flags: review?(dao+bmo) → review+
Ok, we I filed bug 1296395 to remove that selector from some of the other rules.
https://hg.mozilla.org/integration/fx-team/rev/e7cfd78dee27a013c4e5be92e56d76080ffaf85d
Bug 1294885 - Apply padding to the start and end of the Bookmarks Toolbar so bookmark items don't appear abutted to the edge of the window. r=dao
https://hg.mozilla.org/mozilla-central/rev/e7cfd78dee27
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
This Bug was about to implement padding from the edge of the window at bookmarks toolbar. I have seen the feature being implemented with Nightly 51.0a1 on Windows 8.1 (64 Bit!).

This bug's fix is verified on Latest Nightly 51.0a1.
Build ID : 20160831030224
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160831]
Thanks!
Status: RESOLVED → VERIFIED
Depends on: 1318869
Depends on: 1352042
You need to log in before you can comment on or make changes to this bug.