Closed Bug 1294898 Opened 8 years ago Closed 8 years ago

Allow Amazon.com tile to be localised

Categories

(Firefox for iOS :: Localization, defect, P1)

All
iOS
defect

Tracking

()

RESOLVED FIXED
Iteration:
1.5
Tracking Status
fxios 6.0+ ---

People

(Reporter: iannbugzilla, Assigned: farhan)

References

Details

(Whiteboard: [MobileAS])

Attachments

(1 file)

48 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
See Storage/DefaultSuggestedSites.swift. ni jhugman who created that file in the first place, and is conveniently geographically located to test -- this might be an easy thing to tweak, if we have the assets. Marking tracking? to decide whether or not this is worth doing for 5.1.
tracking-fxios: --- → ?
Flags: needinfo?(jhugman)
Hardware: Other → All
Talked with sleroux today, we are already code complete for 5.1 and they want to do the RC release on Monday. FWIW from an l10n perspective, we don't need this in 5.1 - it can definitely wait a later release
Currently the suggested sites can only be localized on a per-set-of-suggested-sites basis. So the simplest fix is to add a en_GB specialization of the whole set for the domains (en.wikipedia.org, amazon.co.uk, twitter.co.uk) and reuse the titles and assets. Only the amazon.co.uk asset will need to be changed.
Flags: needinfo?(jhugman)
Priority: -- → P2
Whiteboard: [MobileAS]
Rank: 3
Assignee: nobody → fpatel
Rank: 3 → 30
Priority: P2 → P3
Priority: P3 → P2
Priority: P2 → P1
Attached file Pull Request
Attachment #8792587 - Flags: review?(bnicholson)
Rank: 30 → 10
Any reason to define these here instead of simply as an NSLocalizedString? That way, each translator can provide the Amazon-specific URL for their locale, and we wouldn't have to maintain this list ourselves.
To be honest I'd prefer not to have these kind of settings exposed to localization (that's the same approach we're trying to build for search). Anyhow, that's Delphine's call in case.
Comment on attachment 8792587 [details] [review] Pull Request OK, works for me then.
Attachment #8792587 - Flags: review?(bnicholson) → review+
master d5df9da97892c0560d0b19f462dbaf65b6466bcb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Iteration: --- → 1.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: