Closed
Bug 1294898
Opened 8 years ago
Closed 8 years ago
Allow Amazon.com tile to be localised
Categories
(Firefox for iOS :: Localization, defect, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.5
Tracking | Status | |
---|---|---|
fxios | 6.0+ | --- |
People
(Reporter: iannbugzilla, Assigned: farhan)
References
Details
(Whiteboard: [MobileAS])
Attachments
(1 file)
At the moment for en-GB (and maybe other locales), there is an amazon.com tile:
http://people.mozilla.org/~sarentz/t/l10n-5.1/en-GB/en-GB/iPhone4s-02DefaultTopSites-01.png
http://people.mozilla.org/~sarentz/t/l10n-5.1/en-GB/en-GB/iPhone4s-03MenuOnTopSites-01.png
http://people.mozilla.org/~sarentz/t/l10n-5.1/en-GB/en-GB/iPhone4s-08URLBar-01.png
It would be good to be able to localise it, as it can be for search settings:
http://people.mozilla.org/~sarentz/t/l10n-5.1/en-GB/en-GB/iPhone4s-04Settings-Search.png
Comment 1•8 years ago
|
||
See Storage/DefaultSuggestedSites.swift.
ni jhugman who created that file in the first place, and is conveniently geographically located to test -- this might be an easy thing to tweak, if we have the assets.
Marking tracking? to decide whether or not this is worth doing for 5.1.
Comment 2•8 years ago
|
||
Talked with sleroux today, we are already code complete for 5.1 and they want to do the RC release on Monday.
FWIW from an l10n perspective, we don't need this in 5.1 - it can definitely wait a later release
Comment 3•8 years ago
|
||
Currently the suggested sites can only be localized on a per-set-of-suggested-sites basis. So the simplest fix is to add a en_GB specialization of the whole set for the domains (en.wikipedia.org, amazon.co.uk, twitter.co.uk) and reuse the titles and assets.
Only the amazon.co.uk asset will need to be changed.
Flags: needinfo?(jhugman)
Updated•8 years ago
|
Updated•8 years ago
|
Priority: -- → P2
Updated•8 years ago
|
Updated•8 years ago
|
Whiteboard: [MobileAS]
Updated•8 years ago
|
Rank: 3
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → fpatel
Updated•8 years ago
|
Rank: 3 → 30
Priority: P2 → P3
Assignee | ||
Updated•8 years ago
|
Priority: P3 → P2
Updated•8 years ago
|
Priority: P2 → P1
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8792587 -
Flags: review?(bnicholson)
Updated•8 years ago
|
Rank: 30 → 10
Comment 5•8 years ago
|
||
Any reason to define these here instead of simply as an NSLocalizedString? That way, each translator can provide the Amazon-specific URL for their locale, and we wouldn't have to maintain this list ourselves.
Comment 6•8 years ago
|
||
To be honest I'd prefer not to have these kind of settings exposed to localization (that's the same approach we're trying to build for search). Anyhow, that's Delphine's call in case.
Comment 7•8 years ago
|
||
Comment on attachment 8792587 [details] [review]
Pull Request
OK, works for me then.
Attachment #8792587 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 8•8 years ago
|
||
master d5df9da97892c0560d0b19f462dbaf65b6466bcb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Iteration: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•