Closed Bug 1294994 Opened 7 years ago Closed 7 years ago

EV cert makes all icons in the identity block green

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- verified

People

(Reporter: magicp.jp, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

identity-icon-notification-color.png
18.99 KB, image/png
Details
patch
1.18 KB, patch
Felipe
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160813030202

Steps to reproduce:

1. Start Nightly
2. Go to "Getting Start" (https://www.mozilla.org/en-US/firefox/central/)
3. Check identity icon color
4. Go to "Google home" (https://www.google.com)
5. Check identity icon color


Actual results:

Identity icon color is different by website.

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2069e3662c134694bbab8db555b633faaddf3549&tochange=6af49d08884d76de44efd9387bbe340921652364


Expected results:

Is this intentional? If so, what is this differences? green is more safety? If it is not, should use same color.
Blocks: 1022601
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox50: --- → unaffected
status-firefox51: --- → affected
Component: Untriaged → Theme
OS: Unspecified → All
Hardware: Unspecified → All
Attached patch patch — — Splinter Review 
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

        Attachment #8781412 -
        Flags: review?(felipc)

    
  
Keywords: regression
Priority: -- → P2

    
  
Summary: Different identity icon color by website → EV cert makes all icons in the identity block green

        Attachment #8781412 -
        Flags: review?(felipc) → review+

    
    

    
  
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/475501051886
EV certs shouldn't make all icons in the identity block green. r=felipe

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/475501051886
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox51:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

    
    

    
  
I have reproduced this bug with Nightly 51.0a1 (2016-08-13) on Windows 8.1 , 64 Bit!

This Bug's fix is verified on Latest Nightly  51.0a1
Build ID : 20160823072522
User Agent :Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160824]

    
    

    
  
Thanks!
Status: RESOLVED → VERIFIED

          status-firefox51:
          fixed → verified

    
    

    
  
I have reproduced this bug with Nightly 51.0a1 (2016-08-15) on Linux Mint 18, 64 bit!

The bug's fix is now verified on latest Nightly 51.0a1.

Nightly 51.0a1:
Build ID 	20160830030201
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160831]

          You need to log in
          before you can comment on or make changes to this bug.