1294998 - Unexpected horizontal over scroll effect when panning vertically

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

I just ran into this here: https://blog.risingstack.com/getting-started-with-nodejs-and-mqtt/

If I pan up and down the article, I frequently get over scroll glow on the sides.

Comment 1

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1294998-In-Fennec-only-show-overscroll-effect-for-root-content-r-botond-16081911-1b260a8.patch

The current Fennec overscroll effect in APZ shows even for scrollable frames that are not the root. This can cause excessive overscroll effects to show on some pages. This patch reverts it to the previous behavior of JPZ which only showed overscroll effect for the root content.

Comment 2

[Randall Barker [:rbarker]]

Comment on attachment 8783011 [details] [diff] [review]
0001-Bug-1294998-In-Fennec-only-show-overscroll-effect-for-root-content-r-botond-16081911-1b260a8.patch

Patch had extra junk in it. Canceling review so I can clean it up.

Comment 3

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1294998-In-Fennec-only-show-overscroll-effect-for-root-content-r-botond-16081911-93d3bae.patch

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8783013 [details] [diff] [review]
0001-Bug-1294998-In-Fennec-only-show-overscroll-effect-for-root-content-r-botond-16081911-93d3bae.patch

Review of attachment 8783013 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/apz/public/GeckoContentController.h
@@ +137,5 @@
>     * Notify content that the repaint requests have been flushed.
>     */
>    virtual void NotifyFlushComplete() = 0;
>  
> +  virtual void UpdateOverscrollVelocity(const float aX, const float aY, const bool aIsRootContent) {}

Toplevel |const| on a function argument is superfluous. I don't know why the existing arguments have them, but please don't add more (and feel free to remove the existing ones).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e96e6002ed72
In Fennec only show overscroll effect for root content r=botond

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e96e6002ed72

Comment 7

[Alex Caziuc]

Verified as fixed using the steps provided by James in description with Galaxy Note 5(6.0.1) on Nightly 51.0a1(2016-08-31)