1295018 - Android's Keyboard shouldn't learn new words when Private Tab is opened

Status: RESOLVED DUPLICATE of bug 1266683

(Firefox for Android Graveyard :: Keyboards and IME, enhancement, P3)

Description

[Itiel]

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160726073904

Steps to reproduce:

Not sure if these steps are applicable for all Android devices, it should be reproducible on Samsung Galaxy S5 (Android 5 or 6), with the built-in Samsung Keyboard.

1. Make sure that 'Words Autocomplete' feature is enabled on the Samsung Keyboard Settings
2. Open Private Tab
3. In the address bar, type something that should be unknown to the keyboard's dictionary, for example "loopidoo" or even a URL like "testingtesting.com"
4. Click the "Go to" button


Actual results:

Samsung Keyboard (or possibly any other keyboard, for that matter) learns the newly entered word/URL.


Expected results:

The keyboard shouldn't learn new and unrecognized words, for privacy reasons.

Note that in the built-in Android's browser (Samsung Internet for Android, version 4.0.20-17, on my phone), when Secret Mode is enabled, the Words Autocomplete feature is automatically off, thus the keyboard doesn't learn any new words during the Secret Mode session.

Comment 1

[Evan Tseng [:evanxd]]

> Note that in the built-in Android's browser (Samsung Internet for Android,
> version 4.0.20-17, on my phone), when Secret Mode is enabled, the Words
> Autocomplete feature is automatically off, thus the keyboard doesn't learn
> any new words during the Secret Mode session.

Hi Sebastian,

So does it mean that we should disable the Words Autocomplete feature when Firefox's private tab is on foreground to fix the issue?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #1)
> So does it mean that we should disable the Words Autocomplete feature when
> Firefox's private tab is on foreground to fix the issue?

That's something antlam should decide. But it makes sense to not leak anything about private tabs to other system components. It definitely is a trade-off - not being able to use autocomplete (from the keyboard, not the omnibar!) can be annoying too. Ideally we could say "Use autocomplete but do not learn from this input" - but I guess that's not possible.

Comment 3

[Evan Tseng [:evanxd]]

> Ideally we could say "Use autocomplete but do
> not learn from this input" - but I guess that's not possible.

I think it's not possible.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Talked to antlam. If possible then we should just disable the keyboard's autosuggest feature in private tabs.

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Attachment: suggestion.png

Hi Sebastian
Please find the numbers marked in the attachment
May I double checked with you that you want to disable auto suggestions in 
1. EditText 
2. suggestion from the search engine 
3. Tab history
4. Something around this keyboard.....
It looks like you are talking about 4, but I can't find any suggestion on the keyboard (I'm using Nexus 5, haven't tried other phone)
Or is the only happen in some Samsung device? 
Should I detect the brand of the phone and see if I can do anything on Samsung device's IME? 
Thank you!

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Attachment: device-2016-11-04-143246.png

Sorry this is the correct attachment.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Yeah, this is about the keyboard and might be Samsung specific (I didn't see this on my devices as well). Do you have access to a Samsung phone in the Taipei office? Otherwise it might be good to order/expense one - Samsung phones are used a lot by our users (I'll flag tim too!).

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We would have to order and expense an Samsung phone (better not be Note 7!)

Comment 9

[Itiel]

(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> Yeah, this is about the keyboard and might be Samsung specific (I didn't see
> this on my devices as well). Do you have access to a Samsung phone in the
> Taipei office? Otherwise it might be good to order/expense one - Samsung
> phones are used a lot by our users (I'll flag tim too!).

I can attach screenshots proving this issue, if needed..
I think this issue SHOULD be samsung specific as Samsung Keyboard, well, exists on samsung devices only.
Though, it would be a good idea to check if other phones (using the default built-in keyboard [with Words Autocomplete feature on] and browser) are behaving the same as Samsung does in this matter, and act accordingly (e.g. disable the Words Autocomplete on these brands, while surfing on a private tab).

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Since there are other bugs related to Samsung devices with different models(https://bugzilla.mozilla.org/buglist.cgi?quicksearch=samsung&list_id=13299612), I suggest to make a plan for Samsung device support in the future.

For the time being, I'll test on Samsung Remote Test Lab (http://developer.samsung.com/remotetestlab/rtlDeviceList.action#) and try to fix the issue.

Since it's only a mirror of the remote device's screen, I can't get logcat output for debugging. If the bug still can't be fixed, I suggest to leave this bug open and fix it in the future.

Comment 11

[Nevin Chen(Not active on Bugzilla)]

Attachment: 01478577874831.png

Thank you for your information ItielMaN!

But I can't reproduce the issue.
I entered the word "apple" and "hot dog" in private mode. But the app didn't remember my input in normal mode.
For some reason I can't install my APK on S5 , below is my test device spec:

Model : Samsung Galaxy Note 4
Device: SM-N910F-KR1
OS Ver: ANDROID 5.0.1

May I know what keyboard (IME) were you using? Is it also a Samsung keyboard?
Maybe the vm in test lab is different with the one in your local distribution.
Besides, can you help me check if the setting for your IME suggestion is turned off?
Thank you!

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Alternatively, once we have local patch ready, we can generate the test builds with try server and have people to install it and take a look.

Comment 13

[Itiel]

(In reply to Nevin Chen [:nechen] from comment #11)
> Created attachment 8808474 [details]
> 01478577874831.png
> 
> Thank you for your information ItielMaN!
> 
> But I can't reproduce the issue.
> I entered the word "apple" and "hot dog" in private mode. But the app didn't
> remember my input in normal mode.
> For some reason I can't install my APK on S5 , below is my test device spec:
> 
> Model : Samsung Galaxy Note 4
> Device: SM-N910F-KR1
> OS Ver: ANDROID 5.0.1

You'd have to enter words that the keyboard doesn't have in it's dictionary. But that doesn't matter as the Words Autocomplete feature seems to be (according to your screenshot) disabled on your Samsung Keyoard's settings (is it?).

(In reply to Nevin Chen [:nechen] from comment #11)
> May I know what keyboard (IME) were you using? Is it also a Samsung keyboard?
> Maybe the vm in test lab is different with the one in your local
> distribution.
> Besides, can you help me check if the setting for your IME suggestion is
> turned off?
> Thank you!

Yes, it's Samsung Keyboard.
Not sure I understand you second question regarding the IME suggestion.

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Nevin Chen [:nechen] from comment #10)
> Since it's only a mirror of the remote device's screen, I can't get logcat
> output for debugging. If the bug still can't be fixed, I suggest to leave
> this bug open and fix it in the future.

That's fine by me. This hasn't a very high priority and is more like a nice-to-have enhancement.