Remove definition of error numbers in portable.h for Windows.

RESOLVED FIXED in Thunderbird 55.0

Status

MailNews Core
LDAP Integration
--
minor
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: frg, Assigned: frg)

Tracking

unspecified
Thunderbird 55.0
Unspecified
Windows

Thunderbird Tracking Flags

(thunderbird55 fixed, seamonkey2.52 fixed)

Details

Attachments

(1 attachment)

886 bytes, patch
Jorg K (GMT+2) (bustage-fix only, NI for urgent reviews)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

2 years ago
portable.h defines the following error numbers on Windows which result in a Macro redefinision warning during compile because they are in errno.h since VS2010:

#define EMSGSIZE WSAEMSGSIZE
#define EWOULDBLOCK WSAEWOULDBLOCK
#define EHOSTUNREACH WSAEHOSTUNREACH

I believe the definition can just be removed.
(Assignee)

Comment 1

2 years ago
Created attachment 8780917 [details] [diff] [review]
1295032-errno.patch

Simple patch. Suite compiles with it but unable to test because no ldap in the house.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #8780917 - Flags: review?(Pidgeot18)
Comment on attachment 8780917 [details] [diff] [review]
1295032-errno.patch

For me, LDAP gives 500.000 compile warnings, with this patch there are a few less ;-)

I don't fully understand this business here, see for example:
https://dxr.mozilla.org/comm-central/search?q=EWOULDBLOCK&redirect=false
which is also defined to 35 a few times.

Anyway, let's see how we go with this.
Attachment #8780917 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 3

a year ago
https://hg.mozilla.org/comm-central/rev/d6892a4d5a3b27319550ab99c20d0cbf8bc334a8
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-seamonkey2.52: --- → fixed
status-thunderbird55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.