portable.h defines the following error numbers on Windows which result in a Macro redefinision warning during compile because they are in errno.h since VS2010: #define EMSGSIZE WSAEMSGSIZE #define EWOULDBLOCK WSAEWOULDBLOCK #define EHOSTUNREACH WSAEHOSTUNREACH I believe the definition can just be removed.
Created attachment 8780917 [details] [diff] [review] 1295032-errno.patch Simple patch. Suite compiles with it but unable to test because no ldap in the house.
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attachment #8780917 - Flags: review?(Pidgeot18)
Comment on attachment 8780917 [details] [diff] [review] 1295032-errno.patch For me, LDAP gives 500.000 compile warnings, with this patch there are a few less ;-) I don't fully understand this business here, see for example: https://dxr.mozilla.org/comm-central/search?q=EWOULDBLOCK&redirect=false which is also defined to 35 a few times. Anyway, let's see how we go with this.
Attachment #8780917 - Flags: review?(Pidgeot18) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-seamonkey2.52: --- → fixed
status-thunderbird55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.