1295138 - Change NS_ASSERTION(false, "Existing entry in StartupCache.") to a NS_WARNING

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Bob Clary [:bc] (inactive)]

https://dxr.mozilla.org/mozilla-central/rev/6e191a55c3d23e83e6a2e72e4e80c1dc21516493/startupcache/StartupCache.cpp#358 fires frequently and randomly on Android tests running in Autophone automation.

The comment following reads "// Double-caching is undesirable but not an error." so this is not really an error condition that requires a fix.

It causes oranges on the Autophone unit tests which increases the work load of the sheriffs and reduces the usefulness of the tests. I would like to change this to a warning that does not make tests orange in automation.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: startupcache.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ad827f382ec
Change NS_ASSERTION(false, "Existing entry in StartupCache.") to a NS_WARNING, r=nfroyd

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This appears to have caused some test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=33855099&repo=mozilla-inbound
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/31e1eb67dd23

Comment 4

[Bob Clary [:bc] (inactive)]

Attachment: startupcache-2.patch

Wes, Thanks and Sorry. This appears to be the sole failure.

16:50:25     INFO -  [1544] WARNING: Existing entry in StartupCache.: file /home/worker/workspace/build/src/startupcache/StartupCache.cpp, line 358
16:50:25     INFO -  MEMORY STAT | vsize 1008MB | residentFast 252MB | heapAllocated 102MB
16:50:25     INFO -  177 INFO TEST-OK | js/xpconnect/tests/chrome/test_chrometoSource.xul | took 504ms
16:50:25     INFO -  ++DOMWINDOW == 129 (0x7f20425e1400) [pid = 1544] [serial = 307] [outer = 0x7f2046b0e400]
16:50:25     INFO -  178 INFO TEST-UNEXPECTED-OK | js/xpconnect/tests/chrome/test_chrometoSource.xul | Assertion count 0 is less than expected range 1-1 assertions.

The patch removes the expected assertion. To avoid a repeat of this failure, I've submitted this to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6c18f9e0f3c

Comment 5

[Bob Clary [:bc] (inactive)]

Comment on attachment 8781243 [details] [diff] [review]
startupcache-2.patch

Wes, this looks ok to me. linux x86_64 debug M(c3) is ok and I didn't find any other instances of unexpected ok failures.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68e2e8cbda41
Change NS_ASSERTION(false, "Existing entry in StartupCache.") to a NS_WARNING, r=nfroyd
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac65411ca573
remove expected assertion from test_chrometoSource.xul, r=nfroyd

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/68e2e8cbda41
https://hg.mozilla.org/mozilla-central/rev/ac65411ca573