Closed
Bug 1295163
Opened 8 years ago
Closed 7 years ago
TLS 1.3: anti-replay for 0-RTT
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.33
People
(Reporter: ekr, Assigned: mt)
References
Details
Attachments
(1 file, 1 obsolete file)
|
824 bytes,
patch
|
mt
:
review+
mt
:
checked-in+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → ekr
|
Assignee | |
Updated•7 years ago
|
Assignee: ekr → martin.thomson
Summary: TLS 1.3: Enforce limits on ticket_age for anti-replay → TLS 1.3: anti-replay for 0-RTT
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/e63b527213546bbabeed4f5daae26acea340ae30 https://hg.mozilla.org/projects/nss/rev/216e69dcc3c64ec405d3dc160661de8678a40acc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.33
While investigating another bug, I have noticed that these tests were not instantiated, see patch.
|
||
Updated•7 years ago
|
Attachment #8915370 -
Flags: review?(martin.thomson)
|
|
Assignee | |
Comment 4•7 years ago
|
||
Comment on attachment 8915370 [details] [diff] [review] 1-Bug_1295163___Actually_enable_TlsZeroRttReplayTest.patch Review of attachment 8915370 [details] [diff] [review]: ----------------------------------------------------------------- ::: gtests/ssl_gtest/ssl_0rtt_unittest.cc @@ +135,5 @@ > +#ifndef NSS_DISABLE_TLS_1_3 > +INSTANTIATE_TEST_CASE_P(Tls13ZeroRttReplayTest, TlsZeroRttReplayTest, > + TlsConnectTestBase::kTlsVariantsStream); > +#endif > + This really needs to go at the end of the file.
Attachment #8915370 -
Flags: review?(martin.thomson) → review+
v2: moved to end of file, still builds and passes the Tls13ZeroRttReplayTest/TlsZeroRttReplayTest.* tests.
Attachment #8915370 -
Attachment is obsolete: true
Attachment #8915998 -
Flags: review?(martin.thomson)
|
|
Assignee | |
Comment 6•7 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/a0cb1758c33fc179135d5688851105e8812375ee I made a minor change: the test tests all variants.
|
|
Assignee | |
Comment 7•7 years ago
|
||
Comment on attachment 8915998 [details] [diff] [review] 1-Bug_1295163___Actually_enable_TlsZeroRttReplayTest.patch Review of attachment 8915998 [details] [diff] [review]: ----------------------------------------------------------------- Oops, left the flag set.
Attachment #8915998 -
Flags: review?(martin.thomson)
Attachment #8915998 -
Flags: review+
Attachment #8915998 -
Flags: checked-in+
You need to log in
before you can comment on or make changes to this bug.
Description
•