1295225 - by-test-platform does not allow regex

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Geoff Brown [:gbrown]]

As discussed in email a couple of weeks ago ("Different test invocations for different platforms"), I think that allowing a regex in by-test-platform would be very convenient for the upcoming addition of windows and mac test task configurations.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: allow regex in get_keyed_by()

I don't think we are quite ready to use this, but I've updated the desktop tests.yml in preparation.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8781217 [details] [diff] [review]
allow regex in get_keyed_by()

Review of attachment 8781217 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks fine, and does exactly what it promises..

But I wonder at the wisdom of using regexes - "win.*" looks like "anything beginning with "win." to the untrained eye.  This is going to run up against our habit of naming things randomly, and we're going to have a regex like "(w\d+.*|win.*)" which starts to lose something in the "readability" department.

Still, r+.  If this ends up complicated, we can try something else (I'm thinking a transform with a list of platforms that categorizes them into runtime environments, then using "by-runtime-environment: win: .., macosx: .., linux: ..").

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28b32da382a3
Allow regex in taskcluster by-test-platform; r=dustin

Comment 4

[Geoff Brown [:gbrown]]

I hear you, and I'm not opposed to a better solution!

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/28b32da382a3