All users were logged out of Bugzilla on October 13th, 2018

by-test-platform does not allow regex

RESOLVED FIXED in mozilla51

Status

RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

unspecified
mozilla51

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
As discussed in email a couple of weeks ago ("Different test invocations for different platforms"), I think that allowing a regex in by-test-platform would be very convenient for the upcoming addition of windows and mac test task configurations.
(Assignee)

Comment 1

2 years ago
Created attachment 8781217 [details] [diff] [review]
allow regex in get_keyed_by()

I don't think we are quite ready to use this, but I've updated the desktop tests.yml in preparation.
Attachment #8781217 - Flags: review?(dustin)
Comment on attachment 8781217 [details] [diff] [review]
allow regex in get_keyed_by()

Review of attachment 8781217 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks fine, and does exactly what it promises..

But I wonder at the wisdom of using regexes - "win.*" looks like "anything beginning with "win." to the untrained eye.  This is going to run up against our habit of naming things randomly, and we're going to have a regex like "(w\d+.*|win.*)" which starts to lose something in the "readability" department.

Still, r+.  If this ends up complicated, we can try something else (I'm thinking a transform with a list of platforms that categorizes them into runtime environments, then using "by-runtime-environment: win: .., macosx: .., linux: ..").
Attachment #8781217 - Flags: review?(dustin) → review+

Comment 3

2 years ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28b32da382a3
Allow regex in taskcluster by-test-platform; r=dustin
(Assignee)

Comment 4

2 years ago
I hear you, and I'm not opposed to a better solution!

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/28b32da382a3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

8 months ago
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.