As pointed out by Gijs in https://bugzilla.mozilla.org/show_bug.cgi?id=1246034#c9, it may be possible for _execute_browser_action to close the PageAction popup if it is showing. We should make sure that this won't happen and add in the necessary tests to confirm it.
I think the correct behavior is actually to close the pageAction popup and then execute the browserAction.
Can i work on this as my first bug? Thanks
Yes! Again, ask if you get stuck.
Not really sure how to start here. To me it looks like the first step is to try to get a browser action to close the pageAction popup before trying to account for that. How do I recreate this possible issue? Thanks
(In reply to Steven Ellul from comment #4) > Not really sure how to start here. > > To me it looks like the first step is to try to get a browser action to > close the pageAction popup before trying to account for that. I think this sounds like the right way to start. The first step would be to add a test to http://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_commands_execute_browser_action.js which opens a page action popup and then uses the shortcut to execute the browser action. The test should check to see if the browser action popup is shown and since this isn't fixed yet the test should fail. The second step would be to fix the issue by closing the page action popup before executing the browser action. I think the code to close the page action popup would go before this line here: https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/ext-commands.js#133. The last step would be to confirm that the test passes now. If so, you're all done :) Here's some more information on how to write the test: - An example test to follow: http://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_commands_execute_browser_action.js#106 - How to handle options passed into the test: http://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_commands_execute_browser_action.js#21 - To open the page action popup you'll first need to show the page action - http://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_commands_execute_page_action.js#101, and then you can open it using https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_pageAction_popup.js#146. Writing the test for this might be a little tricky, so please ping me if you would like any more help (my irc nick is `k9`).
I'm usually around in #webextensions, and I'm sure others there would be happy to help out as well.
Unassigned myself. Sorry to have prevented others working on this, but I was a bit silly asking to be assigned to this bug because it is outside of my skill set.
Created attachment 8881082 [details] [diff] [review] 1295276-close-the-page-action-popup-just-before-handling-_execute_browser_action.diff Here's a patch to close the page action popup before _execute_browser_action, as per comment 5. A try run seems fine, there just appear to be unrelated intermittents: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f021dda0162f6390352b194de6006f0cf190ad38