Closed Bug 1295380 Opened 3 years ago Closed 3 years ago

Really run tests with run-task

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla51

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1294234 +++

We tried to switch tests to use run-task in bug 1294234 but I had to back out that commit from the series because of intermittent permissions errors. I think the conversion to run-task somehow resulted in some tasks running as worker:worker instead of root:root.

Let's figure out what went wrong and finish up that conversion.
Comment on attachment 8781605 [details]
Bug 1295380 - Use run-task for test tasks;

https://reviewboard.mozilla.org/r/72000/#review69488

This commit was pretty much already reviewed in bug 1294234. The main difference is the introduction of --chown to ensure permissions on the workspace cache/volume are happy.
Comment on attachment 8781604 [details]
Bug 1295380 - Teach run-task to chown paths;

https://reviewboard.mozilla.org/r/71998/#review70300
Attachment #8781604 - Flags: review?(dustin) → review+
Comment on attachment 8781605 [details]
Bug 1295380 - Use run-task for test tasks;

https://reviewboard.mozilla.org/r/72000/#review70302
Attachment #8781605 - Flags: review?(dustin) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/213a4986ccfd
Teach run-task to chown paths; r=dustin
https://hg.mozilla.org/integration/autoland/rev/905fb4a53386
Use run-task for test tasks; r=dustin
Backed out in https://hg.mozilla.org/integration/autoland/rev/f90d73ed0269 because Treeherder is going to require some changes before it can read the changes to log formats.
Flags: needinfo?(gps)
Depends on: 1297184
Bug 1297184 is deployed to treeherder stage. Once that makes it to production, we should be clear to reland this.
Flags: needinfo?(gps)
https://hg.mozilla.org/mozilla-central/rev/805d466424e4
https://hg.mozilla.org/mozilla-central/rev/4fc36d02980f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Blocks: 1302821
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.