Links to WPT viewer should use https

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: robwu, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
1. Visit the try results, e.g. https://treeherder.mozilla.org/#/jobs?repo=try&revision=61310b9f8d5b&selectedJob=25745368
2. Click on any test, e.g. B, M, 1.
3. Now a panel appears at the bottom, where links to artifacts are shown ("artifact uploaded: ..."). Note that "open in test results viewer" links to mozilla.github.io, e.g.
http://mozilla.github.io/wptview/#/?urls=http%3A%2F%2Fmozilla-releng-blobs.s3.amazonaws.com%2Fblobs%2Ftry%2Fsha512%2F0420d2071b0b30979f763b9177d52285b09a2678259994aecb0b505cf24429bad5e80a237dd1d1bdf7b9a02eac08fd76306f316167b38a093d7cb8e8883821c4,Ubuntu%20VM%2012.04%20x64%20try%20opt%20test%20mochitest-1

With HTTPS Everywhere, mozilla.github.io is rewritten to https:. But because "urls" is a http URL, the request is blocked due to mixed content.

Switching the links from http to https would solve this issue.
(Assignee)

Comment 1

2 years ago
I was under the impression that this should be fixed after bug 1281644 got deployed.
Flags: needinfo?(emorley)
(In reply to Wes Kocher (:KWierso) from comment #1)
> I was under the impression that this should be fixed after bug 1281644 got
> deployed.

That bug was just about the log URLs, this is a link to the WPT viewer on GitHub, which comes from here:
https://github.com/mozilla/treeherder/blob/f7b3d2f67d218580d8d5be97d558c5e72e57360d/ui/plugins/job_details/main.html#L8

Would you be up for opening a PR to update that? There are also a few other http URLS in the repo that should probably be updated (eg: "http://people.mozilla.com/~bgirard/cleopatra/" -> "https://people.mozilla.org/~bgirard/cleopatra/" + comment URLs to various sites + reftest analyser link on the log viewer page etc).

I've also filed an issue against the WPT viewer asking that they enable the GitHub Pages "enforce HTTPS" option for that project:
https://github.com/mozilla/wptview/issues/144
Blocks: 1251988
Flags: needinfo?(emorley)
Summary: Treeherder links to artifact over http instead of http → Links to WPT viewer should use https
(Assignee)

Comment 3

2 years ago
Can do.
Assignee: nobody → wkocher
Created attachment 8782233 [details] [review]
[treeherder] KWierso:1295382 > mozilla:master
(Assignee)

Comment 5

2 years ago
Comment on attachment 8782233 [details] [review]
[treeherder] KWierso:1295382 > mozilla:master

All of these appear to work under https from a quick test.
Attachment #8782233 - Flags: review?(emorley)
Comment on attachment 8782233 [details] [review]
[treeherder] KWierso:1295382 > mozilla:master

r+ with comments addressed :-)
Attachment #8782233 - Flags: review?(emorley) → review+
(Assignee)

Comment 7

2 years ago
Unsure why it didn't autocomment, but I fixed this up and landed it in https://github.com/mozilla/treeherder/commit/e0789f2478daa3c48a5deb3bee92eb73481740d5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(In reply to Wes Kocher (:KWierso) from comment #7)
> Unsure why it didn't autocomment

The GitHub hooks page showed timeouts for the Bugzilla, Read the Docs and Reviewable hooks. I think GitHub must have just been having problems.
You need to log in before you can comment on or make changes to this bug.