129546 - Need to have views reparented with their widgets

Status: RESOLVED WORKSFORME

(Core :: Web Painting, defect)

Description

[rods (gone)]

In nsHTMLContainerFrame we reparent a view, but its widget doesn't get
reparented. The test example for this is to have a document with an iframe about
line or so lines down the page and then go into print preview. During layout the
iframe gets moved from the first page to the second. 

We need to add a new method to the ViewManager to assist with this. The problem
is that we need to look upward in the view hierarchy AND downward in the view
hierarchy to make sure all views with widgets get parented correctly.

The new method could be:
ReparentView(nsIView* aNewParent, nsIView* aViewToMove);

The inside nsHTMLContainerFrame in the static method ReparentFrameViewTo we
would change the RemoveChild and InsertChild calls to ReparentView

Comment 1

[Kevin McCluskey (gone)]

Bulk moving all nsbeta1 nominations to future-P1. If they are approved
(nsbeta1+) they will be moved to mozilla1.0

Comment 2

[Kevin McCluskey (gone)]

The nsIWidget interface does not provide methods to reparent the widget. We
would have to add platform specific methods to reparent the widgets.

This bug fix is needed only for print preview. In print preview each page has a
widget and during the reflow process frames get pushed between pages. A view
that was initially reflowed onto page 1 and had a widget may end up being
reflowed to page 2. If this happens the views widget needs to be reparented.  

Marking nsbeta1-, until we decide how we want solve the print preview issue.

Comment 3

[Boris Zbarsky [:bzbarsky]]

To roc, I guess.....

Comment 4

[Timothy Nikkel (:tnikkel)]

I don't think this is a problem anymore.