1295541 - Move mInitPromise.DisconnectIfExists() into DecoderData::ShutdownDecoder()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[JW Wang [:jwwang] [:jw_wang]]

When we shut down a decoder, we should always disconnect the init promise. Hope this will fix bug 1295146.

https://hg.mozilla.org/mozilla-central/file/054d4856cea6150a6638e5daf7913713281af97d/dom/media/MediaFormatReader.cpp#l2119

Note SetVideoBlankDecode() shuts down the decoder without disconnect the init promise which might be the cause of bug 1295146.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1295541 - Move mInitPromise.DisconnectIfExists() into DecoderData::ShutdownDecoder().

Review commit: https://reviewboard.mozilla.org/r/71930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71930/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8781519 [details]
Bug 1295541 - Move mInitPromise.DisconnectIfExists() into DecoderData::ShutdownDecoder().

https://reviewboard.mozilla.org/r/71930/#review69602

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c239558f86a3
Move mInitPromise.DisconnectIfExists() into DecoderData::ShutdownDecoder(). r=jya

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c239558f86a3