Typing about: into the URL bar immediately crashes browser

RESOLVED FIXED in Firefox 50

Status

()

Firefox for Android
Favicon Handling
P1
blocker
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kats, Assigned: sebastian, NeedInfo)

Tracking

50 Branch
Firefox 51
All
Android
Points:
---

Firefox Tracking Flags

(firefox49 unaffected, firefox50- fixed, firefox51 unaffected)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Created attachment 8781615 [details]
Java stack

100% reproducible on aurora for me. I tried to go to about:crashes but after typing the 'about:' part of the URL fennec crashes. Java stack attached.
Seems to not affect beta/nightly. But maybe it's dependent on what I have in my profile?
status-firefox49: --- → unaffected
status-firefox51: --- → unaffected
(Assignee)

Comment 2

a year ago
I can't reproduce this on my device. I think you are only seeing it on Aurora because it's some URL in your history. According to the stacktrace the favicon loading code explodes.
Is anyone else able to reproduce this crash? Adding ni on Ioana.
Flags: needinfo?(ioana.bugs)
Trying to see if Teodora can help repro this. Unless this is something that impacts a lot of users, I will be inclined to tracking "-" for 50.
Flags: needinfo?(teodora.vermesan)
I've since cleared my profile and can't repro this any more. That being said, the stack trace I attached clearly points to a bug that should be easily fixable.
I can't reproduce this issue on several devices. I'll investigate more and if I can reproduce it, I'll provide a feedback.
Flags: needinfo?(teodora.vermesan)
pageURL can clearly be null at http://searchfox.org/mozilla-central/rev/b38dbd1378cea4ae83bbc8a834cdccd02bbc5347/mobile/android/base/java/org/mozilla/gecko/home/TwoLinePageRow.java#299, and when that gets passed into the favicon code it blows up.
Hi Sebastian, Kats has potentially root-caused the problem in comment7. Could you please help find an owner to try a potential fix? I'd be happy to uplift to Aurora if deemed low risk.
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 9

a year ago
Ah, thanks. That's exactly one of the cases we identified in bug 1297117.
Blocks: 1297117
Flags: needinfo?(s.kaspari)
Priority: -- → P1
(Assignee)

Updated

a year ago
Assignee: nobody → s.kaspari
(Assignee)

Updated

a year ago
Whiteboard: [MobileAS]
Comment hidden (mozreview-request)

Comment 11

a year ago
mozreview-review
Comment on attachment 8784316 [details]
Bug 1295639 - TwoLinePageRow: Use stripAboutReaderUrl() instead of getUrlFromAboutReader().

https://reviewboard.mozilla.org/r/73816/#review72082
Attachment #8784316 - Flags: review?(ahunt) → review+
(Assignee)

Comment 12

a year ago
mozreview-review
Comment on attachment 8784316 [details]
Bug 1295639 - TwoLinePageRow: Use stripAboutReaderUrl() instead of getUrlFromAboutReader().

https://reviewboard.mozilla.org/r/73816/#review72094
Attachment #8784316 - Flags: review+

Comment 13

a year ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/62b153717ab0
TwoLinePageRow: Use stripAboutReaderUrl() instead of getUrlFromAboutReader(). r=ahunt

Comment 14

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/62b153717ab0
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Hey Sebastian, could you please nominate for uplift to Aurora50?
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 16

a year ago
Comment on attachment 8784316 [details]
Bug 1295639 - TwoLinePageRow: Use stripAboutReaderUrl() instead of getUrlFromAboutReader().

Approval Request Comment

[Feature/regressing bug #]: This is a bug that is only reproducible if you have a specific type of URL in your history (One that looks like a reader mode URL but isn't really).

[User impact if declined]: The app will crash when such a URL is in the history of the user.

[Describe test coverage new/current, TreeHerder]: Only local testing.

[Risks and why]: Very low - Instead of transforming the 'broken' reader mode URL into 'null' and therefore crashing the app, we just use the URL as-is.

[String/UUID change made/needed]: -
Flags: needinfo?(s.kaspari)
Attachment #8784316 - Flags: approval-mozilla-aurora?
Hey Kats, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(bugmail)
Comment on attachment 8784316 [details]
Bug 1295639 - TwoLinePageRow: Use stripAboutReaderUrl() instead of getUrlFromAboutReader().

Crash fix, Aurora50+
Attachment #8784316 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have since cleared my profile and can't repro the issue any more, so I can't really verify the fix.
Flags: needinfo?(bugmail)

Comment 20

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/5f96fd506060
status-firefox50: affected → fixed
No need to track it since it's already fixed.
tracking-firefox50: ? → -
Version: unspecified → 50 Branch
Iteration: --- → 1.3
You need to log in before you can comment on or make changes to this bug.