Build byteorder crate seperately

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(2 attachments)

We've been hacking the rust mp4parse build to include the byteorder dependency crate as an internal module. Now that bug 1231764 has landed cargo support in the build system we can include the crate directly and just add a path dependency to direct cargo to the in-tree copy.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8781642 [details]
Bug 1295666 - Import byteorder as a separate crate.

https://reviewboard.mozilla.org/r/72022/#review69638
Attachment #8781642 - Flags: review?(kinetik) → review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8781643 [details]
Bug 1295666 - Build byteorder as a separate crate.

https://reviewboard.mozilla.org/r/72024/#review69642
Attachment #8781643 - Flags: review?(kinetik) → review+

Comment 5

2 years ago
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a9f74cba5c7
Import byteorder as a separate crate. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/3888bbf8bcea
Build byteorder as a separate crate. r=kinetik

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6a9f74cba5c7
https://hg.mozilla.org/mozilla-central/rev/3888bbf8bcea
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.