Closed Bug 1295666 Opened 4 years ago Closed 4 years ago

Build byteorder crate seperately

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(2 files)

We've been hacking the rust mp4parse build to include the byteorder dependency crate as an internal module. Now that bug 1231764 has landed cargo support in the build system we can include the crate directly and just add a path dependency to direct cargo to the in-tree copy.
Comment on attachment 8781642 [details]
Bug 1295666 - Import byteorder as a separate crate.

https://reviewboard.mozilla.org/r/72022/#review69638
Attachment #8781642 - Flags: review?(kinetik) → review+
Comment on attachment 8781643 [details]
Bug 1295666 - Build byteorder as a separate crate.

https://reviewboard.mozilla.org/r/72024/#review69642
Attachment #8781643 - Flags: review?(kinetik) → review+
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a9f74cba5c7
Import byteorder as a separate crate. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/3888bbf8bcea
Build byteorder as a separate crate. r=kinetik
You need to log in before you can comment on or make changes to this bug.