1295666 - Build byteorder crate seperately

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Ralph Giles (:rillian)]

We've been hacking the rust mp4parse build to include the byteorder dependency crate as an internal module. Now that bug 1231764 has landed cargo support in the build system we can include the crate directly and just add a path dependency to direct cargo to the in-tree copy.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1295666 - Import byteorder as a separate crate.

Now that bug 1231764 has landed cargo support in the build system,
we can remove the patches hacking the byteorder crate into a
module within the mp4parse crate.

This updates the import script to copy the byteorder source
files to a separate directory and removes the obsolete patches.

We update the patch against mp4parse/Cargo.toml to add a dependency
path referring to the new source location. This tells cargo to use
the in-tree copy instead of trying to pull from a registery.

Review commit: https://reviewboard.mozilla.org/r/72022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72022/

Comment 2

[Ralph Giles (:rillian)]

Attachment: Bug 1295666 - Build byteorder as a separate crate.

Run the updated import script to split the in-tree byteorder
code into a separate directory and build it as a dependent crate.

Review commit: https://reviewboard.mozilla.org/r/72024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72024/

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8781642 [details]
Bug 1295666 - Import byteorder as a separate crate.

https://reviewboard.mozilla.org/r/72022/#review69638

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8781643 [details]
Bug 1295666 - Build byteorder as a separate crate.

https://reviewboard.mozilla.org/r/72024/#review69642

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a9f74cba5c7
Import byteorder as a separate crate. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/3888bbf8bcea
Build byteorder as a separate crate. r=kinetik

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6a9f74cba5c7
https://hg.mozilla.org/mozilla-central/rev/3888bbf8bcea