1295684 - Make JSObject2WrappedJSMap infallible

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

If we make this map infallible, then we'll get better crash reports for bug 1295033.

Comment 1

[Andrew McCreight [:mccr8]]

This patch is very trivial once bug 1295695 is fixed.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1295684 - Make JSObject2WrappedJSMap infallible.

We crash sometimes if we fail to add. We should always crash, because
we don't properly attempt to handle failure, and it would be nice to
get proper OOM-annotated crash reports.

Review commit: https://reviewboard.mozilla.org/r/72756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72756/

Comment 3

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=833e56932029

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8782687 [details]
Bug 1295684 - Make JSObject2WrappedJSMap infallible.

https://reviewboard.mozilla.org/r/72756/#review70816

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7fb2505cf58
Make JSObject2WrappedJSMap infallible. r=mrbkap

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a7fb2505cf58